-
-
Notifications
You must be signed in to change notification settings - Fork 704
Added weeks to afrikaans locale #1234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1234 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 10
Lines ? 2315
Branches ? 358
==========================================
Hits ? 2315
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
jadchaar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but mind removing junit.xml? It was mistakenly pushed and has since been removed and added to gitignore. Updating branch now causes merge conflicts.
|
Done |
|
Hi @oestej mind resolving the conflicts? Then we can merge :) |
|
Done! |
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
Adds week and weeks translations for Afrikaans, adds very basic tests for Afrikaans