Skip to content

Add Navbar navigation to Pricing page (#255) #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaikrasheed6341 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Navbar navigation to Pricing page (#255) #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/web/src/app/(main)/(landing)/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import React from 'react'

import Navbar from '@/components/landing-sections/navbar'
const Layout = ({ children }: { children: React.ReactNode }) => {
return (
<section>
<Navbar />
{children}
</section>
)
Expand Down
5 changes: 2 additions & 3 deletions apps/web/src/app/(main)/(landing)/pricing/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,9 +424,8 @@ const SecondaryPricingCard = ({ callbackUrl }: { callbackUrl: string }) => {
planName="Opensox Pro"
description="Annual Subscription"
buttonText={planIdOk ? "Invest" : "Unavailable"}
buttonClassName={`w-full max-w-[500px] mx-auto font-semibold ${
planIdOk ? "" : "opacity-60 cursor-not-allowed"
}`}
buttonClassName={`w-full max-w-[500px] mx-auto font-semibold ${planIdOk ? "" : "opacity-60 cursor-not-allowed"
}`}
callbackUrl={callbackUrl}
/>
<div className="flex justify-center mt-3">
Expand Down
7 changes: 1 addition & 6 deletions apps/web/src/components/landing-sections/navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,7 @@ const Navbar = () => {
initial={{ opacity: 0 }}
animate={showNavbar ? { opacity: 1 } : { opacity: 0, display: "none" }}
transition={{ duration: 0.3 }}
className={cn(
" z-40 flex items-center justify-between px-4 py-3 bg-neutral-900/5 backdrop-blur-xl border-white/10",
isPricingPage
? "relative h-max md:w-full top-0 border-b"
: "fixed rounded-3xl top-4 border w-[94%] md:w-[80%] mx-auto left-1/2 -translate-x-1/2"
)}
className="z-40 flex items-center justify-between px-4 py-3 bg-neutral-900/5 backdrop-blur-xl border-white/10 fixed rounded-3xl top-4 border w-[94%] md:w-[80%] mx-auto left-1/2 -translate-x-1/2"
>
<div className="flex items-center gap-3">
<button
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/ui/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { colors } from "@/lib/design-tokens";

const Header = ({ title }: { title: string | React.ReactNode }) => {
return (
<div className="px-[30px] py-10 h-[160px] relative overflow-hidden border-b border w-full">
<div className="px-[30px] mt-28 py-10 h-[160px] relative overflow-hidden border-b border w-full">
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check navbar styling and dimensions
fd -t f "navbar" apps/web/src/components/ -x grep -l "fixed"

Repository: apsinghdev/opensox

Length of output: 113

🏁 Script executed:

#!/bin/bash
# Extract navbar styling details
cat -n apps/web/src/components/landing-sections/navbar.tsx | head -80

Repository: apsinghdev/opensox

Length of output: 3631

🏁 Script executed:

#!/bin/bash
# Search for the specific navbar className
rg "className.*fixed" apps/web/src/components/landing-sections/navbar.tsx -A 2 -B 1

Repository: apsinghdev/opensox

Length of output: 353

🏁 Script executed:

#!/bin/bash
# Check design tokens for spacing guidance
cat apps/web/src/lib/design-tokens.ts | head -100

Repository: apsinghdev/opensox

Length of output: 2823

🏁 Script executed:

#!/bin/bash
# Search for other uses of mt-28 or similar large top margins
rg "mt-\[|mt-[0-9]+" apps/web/src/components/ -t tsx -c

Repository: apsinghdev/opensox

Length of output: 89

🏁 Script executed:

#!/bin/bash
# Check if there are other sections with fixed navbar offsets
rg "fixed.*top-" apps/web/src/components/ -t tsx -A 1 | head -20

Repository: apsinghdev/opensox

Length of output: 89

🏁 Script executed:

#!/bin/bash
# Check the header component and surrounding context
cat -n apps/web/src/components/ui/header.tsx

Repository: apsinghdev/opensox

Length of output: 1833

🏁 Script executed:

#!/bin/bash
# Search for other margin usage patterns in web components
rg "mt-\d+" apps/web/src/components/ --type ts --type tsx -o | head -30

Repository: apsinghdev/opensox

Length of output: 89

🏁 Script executed:

#!/bin/bash
# Check where Header component is used to understand context
rg "Header\s*\{" apps/web/src/ --type tsx -B 2 -A 1 | head -40

Repository: apsinghdev/opensox

Length of output: 89

🏁 Script executed:

#!/bin/bash
# Check if there are design/layout guidelines mentioning navbar spacing
fd -type f -name "*.md" apps/web/src/ -exec grep -l "navbar\|spacing\|margin" {} \;

Repository: apsinghdev/opensox

Length of output: 232

🏁 Script executed:

#!/bin/bash
# Search for Header component usage
rg "Header" apps/web/src/components/ -t ts -t tsx -B 1 -A 1 | head -50

Repository: apsinghdev/opensox

Length of output: 89

🏁 Script executed:

#!/bin/bash
# Check tailwind config for spacing scale verification
grep -A 10 "spacing" apps/web/tailwind.config.ts

Repository: apsinghdev/opensox

Length of output: 44

🏁 Script executed:

#!/bin/bash
# Find and check tailwind config
find apps/web -name "tailwind.config.*" -type f

Repository: apsinghdev/opensox

Length of output: 89

🏁 Script executed:

#!/bin/bash
# Check what the standard spacing values are near 30px
cat apps/web/tailwind.config.ts | grep -A 50 "extend" | head -60

Repository: apsinghdev/opensox

Length of output: 1547

🏁 Script executed:

#!/bin/bash
# Verify standard Tailwind spacing scale to confirm px-[30px] violation
cat apps/web/tailwind.config.ts | head -200

Repository: apsinghdev/opensox

Length of output: 6347

🏁 Script executed:

#!/bin/bash
# Check if there are other components using similar patterns
rg "px-\[" apps/web/src/components/ -A 1 -B 1 | head -30

Repository: apsinghdev/opensox

Length of output: 1217

🏁 Script executed:

#!/bin/bash
# Check if px-[30px] pattern is intentional by looking at design system docs
find apps/web/src -name "*.md" -o -name "*.txt" | xargs grep -l "spacing\|padding" 2>/dev/null | head -5

Repository: apsinghdev/opensox

Length of output: 44

🏁 Script executed:

#!/bin/bash
# Check .cursorrules and frontend_rules mentioned in learnings
cat apps/web/.cursor/rules/frontend_rules.mdc

Repository: apsinghdev/opensox

Length of output: 6643

🏁 Script executed:

#!/bin/bash
# Check the border styling in header
grep -n "border-b border" apps/web/src/components/ui/header.tsx

Repository: apsinghdev/opensox

Length of output: 165

🏁 Script executed:

#!/bin/bash
# Check other components to see how they specify border colors
rg "border-b border-" apps/web/src/components/ -t ts -t tsx | head -10

Repository: apsinghdev/opensox

Length of output: 89

🏁 Script executed:

#!/bin/bash
# Check how other components style borders to confirm pattern
rg "border" apps/web/src/components/ui/ -A 0 -B 0 | grep -E "border-" | head -20

Repository: apsinghdev/opensox

Length of output: 3617

Specify the border color class for consistency with the design system.

The border-b border should explicitly reference the design token color: border-b border-border to align with the design system defined in design-tokens.ts.

🤖 Prompt for AI Agents 
In apps/web/src/components/ui/header.tsx around line 9, the div uses the generic
Tailwind border classes "border-b border" instead of the design-system token;
change the class to explicitly use the design token by replacing the second
"border" with "border-border" (i.e., "border-b border-border") so the bottom
border color aligns with design-tokens.ts.

<motion.h4
initial={{ opacity: 0, y: 30, filter: "blur(10px)" }}
animate={{ opacity: 1, y: 0, filter: "blur(0px)" }}
Expand Down