Skip to content

Conversation

@eglitise
Copy link
Contributor

@eglitise eglitise commented Dec 8, 2025

This removes the source-map-support dependency. There are several reasons for this:

  • It was never called in source code, so it was only available in CLI (= not exposed to users)
  • Node 12.12+ already includes this functionality
  • IMO: Utility modules such as this one should strive to reduce their dependencies anyway

More information here: e18e/ecosystem-issues#215

@mykola-mokhnach
Copy link
Contributor

Thanks for checking it @eglitise

Feel free to remove this dependency from other org modules without approval.

@mykola-mokhnach mykola-mokhnach merged commit d58016c into appium:master Dec 9, 2025
6 checks passed
@eglitise eglitise deleted the remove-sms branch December 9, 2025 17:38
@eglitise
Copy link
Contributor Author

eglitise commented Dec 9, 2025

Feel free to remove this dependency from other org modules without approval.

Before I proceed with this, it's worth highlighting that Node's built in functionality for this does require using an additional argument/environment variable (see linked issue). Is it critical enough to preserve? Personally I don't see much benefit from this for the end user.

This was referenced Dec 11, 2025
@github-actions
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants