Skip to content

Cleaner exception handling #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elharo wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −8
Open

Cleaner exception handling #1566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ...ain/java/org/apache/maven/plugins/dependency/fromDependencies/RenderDependenciesMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import java.io.File;
import java.io.IOException;
import java.io.StringWriter;
import java.io.UncheckedIOException;
import java.io.Writer;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
Expand Down Expand Up @@ -154,9 +155,10 @@ protected void doExecute() throws MojoExecutionException {
}

/**
* Do render the template.
* @param artifacts input.
* @return the template rendered.
* Render the template.
*
* @param artifacts input
* @return the template rendered
*/
private String render(final List<Artifact> artifacts) {
final Path templatePath = getTemplatePath();
Expand All @@ -178,20 +180,18 @@ private String render(final List<Artifact> artifacts) {
context.put("sorter", new CollectionTool());

// Merge template + context
final StringWriter writer = new StringWriter();
try (StringWriter ignored = writer) {
try (StringWriter writer = new StringWriter()) {
if (fromFile) {
final Template template =
ve.getTemplate(templatePath.getFileName().toString());
template.merge(context, writer);
} else {
ve.evaluate(context, writer, "tpl-" + Math.abs(hashCode()), template);
}
return writer.toString();
} catch (final IOException e) {
// no-op, not possible
throw new UncheckedIOException("not possible", e);
}

return writer.toString();
}

private Path getTemplatePath() {
Expand Down