HBASE-29645 AsyncBufferedMutatorImpl concurrency improvement #7516

Apache9 · 2025-12-04T14:06:54Z

No description provided.

Co-authored-by: Duo Zhang <zhangduo@apache.org> Co-authored-by: David Manning <david.manning@salesforce.com>

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncBufferedMutatorImpl.java

d-c-manning · 2025-12-05T21:19:54Z

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncBufferedMutatorImpl.java

  @Override
-  public synchronized void flush() {
-    internalFlush();
+  public void flush() {


Considering that the only difference between flush and close is the one statement closed = true... is it worth creating a separate method that can be shared between the two with a parameter for whether to close?

…cBufferedMutatorImpl.java Co-authored-by: d-c-manning <67607031+d-c-manning@users.noreply.github.com>

Apache-HBase · 2025-12-06T15:14:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 34s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 13s		master passed
+1 💚	compile	5m 11s		master passed
+1 💚	checkstyle	1m 43s		master passed
+1 💚	spotbugs	3m 3s		master passed
+1 💚	spotless	1m 6s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 43s		the patch passed
+1 💚	compile	5m 4s		the patch passed
+1 💚	javac	5m 4s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 40s		the patch passed
+1 💚	spotbugs	3m 21s		the patch passed
+1 💚	hadoopcheck	16m 14s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
-1 ❌	spotless	0m 29s		patch has 29 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		58m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7516/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7516
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux e0ad43e410e9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `126c150`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7516/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	132 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7516/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-06T18:18:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 39s		master passed
+1 💚	compile	1m 29s		master passed
+1 💚	javadoc	0m 54s		master passed
+1 💚	shadedjars	6m 16s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 16s		the patch passed
+1 💚	compile	1m 27s		the patch passed
+1 💚	javac	1m 27s		the patch passed
+1 💚	javadoc	0m 50s		the patch passed
+1 💚	shadedjars	6m 12s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	1m 33s		hbase-client in the patch passed.
+1 💚	unit	210m 0s		hbase-server in the patch passed.
		242m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7516/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7516
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 06cda204933f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `126c150`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7516/2/testReport/
Max. process+thread count	4233 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7516/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-06T19:15:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 1s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 54s		master passed
+1 💚	compile	4m 53s		master passed
+1 💚	checkstyle	1m 32s		master passed
+1 💚	spotbugs	2m 41s		master passed
+1 💚	spotless	1m 3s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 26s		the patch passed
+1 💚	compile	4m 59s		the patch passed
+1 💚	javac	4m 59s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 31s		the patch passed
+1 💚	spotbugs	2m 56s		the patch passed
+1 💚	hadoopcheck	14m 3s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 57s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 29s		The patch does not generate ASF License warnings.
		54m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7516/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7516
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 0e0dca086e63 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0c87197`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	134 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7516/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

HBASE-29645 AsyncBufferedMutatorImpl concurrency improvement

442f6e4

Co-authored-by: Duo Zhang <zhangduo@apache.org> Co-authored-by: David Manning <david.manning@salesforce.com>

Apache9 mentioned this pull request Dec 4, 2025

HBASE-29645 Reduce synchronization in AsyncBufferedMutatorImpl #7363

Open

This comment has been minimized.

Sign in to view

d-c-manning approved these changes Dec 5, 2025

View reviewed changes

Apache9 and others added 2 commits December 6, 2025 22:05

Update hbase-client/src/main/java/org/apache/hadoop/hbase/client/Asyn…

126c150

…cBufferedMutatorImpl.java Co-authored-by: d-c-manning <67607031+d-c-manning@users.noreply.github.com>

addressing review comments

0c87197

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-29645 AsyncBufferedMutatorImpl concurrency improvement #7516

HBASE-29645 AsyncBufferedMutatorImpl concurrency improvement #7516

Apache9 commented Dec 4, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

d-c-manning Dec 5, 2025

Uh oh!

Apache-HBase commented Dec 6, 2025

Uh oh!

Apache-HBase commented Dec 6, 2025

Uh oh!

Apache-HBase commented Dec 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HBASE-29645 AsyncBufferedMutatorImpl concurrency improvement #7516

Are you sure you want to change the base?

HBASE-29645 AsyncBufferedMutatorImpl concurrency improvement #7516

Conversation

Apache9 commented Dec 4, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

d-c-manning Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Dec 6, 2025

Uh oh!

Apache-HBase commented Dec 6, 2025

Uh oh!

Apache-HBase commented Dec 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants