[FELIX-6814] Improve Reproducible Build Support #461
+37
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the value of Maven's project.build.outputTimestamp property as the value for the -reproducible instruction. Timestamps, formatted in ISO-8601 or in number of seconds since the epoch, are both supported by bnd tools. The value is also already sanitized by MavenArchiver::parseOutputTimestamp which also allows only numeric timestamps or timestamps in ISO-8601 format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the value of Maven's project.build.outputTimestamp property as the value for the -reproducible instruction.
Timestamps, formatted in ISO-8601 or in number of seconds since the epoch, are both supported by bnd tools. The value is also already sanitized by MavenArchiver::parseOutputTimestamp which also allows only numeric timestamps or timestamps in ISO-8601 format.