Skip to content

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR fixes: #12229
Fixes issue when scaling down k8s clusters deployed in HA mode - indexing issue encountered.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.59%. Comparing base (8936e4c) to head (dd07d7d).

Files with missing lines Patch % Lines
...er/actionworkers/KubernetesClusterScaleWorker.java 62.50% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #12302   +/-   ##
=========================================
  Coverage     17.58%   17.59%           
- Complexity    15580    15584    +4     
=========================================
  Files          5910     5910           
  Lines        529439   529450   +11     
  Branches      64691    64694    +3     
=========================================
+ Hits          93093    93134   +41     
+ Misses       425861   425827   -34     
- Partials      10485    10489    +4     
Flag Coverage Δ
uitests 3.57% <ø> (ø)
unittests 18.66% <62.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Pearl1594
can this be extracted to a method and add some unit tests for it ?

@Pearl1594 Pearl1594 force-pushed the ghi12229-cks-scaledown-ha branch from aa2d006 to dd07d7d Compare December 19, 2025 14:21
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Pearl1594 for the update

@sonarqubecloud
Copy link

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 16111

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kubernetes cluster downscale fails and remains in SCALE state with IllegalArgumentException: fromIndex(x) > toIndex(y) on CloudStack 4.22

3 participants