Skip to content

Conversation

@rp-
Copy link
Contributor

@rp- rp- commented Dec 18, 2025

Description

Instead of providing the very basic /dev/drbd{minorNr} drbd block device path provide the
by-res path, that also includes the cloudstack volume.path

Prerequisite for #12218

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Spun up a fresh Linstor cluster, and checked the new path is used in the libvirt xml

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.23%. Comparing base (e8200a0) to head (49d3e54).

Files with missing lines Patch % Lines
...cloudstack/storage/datastore/util/LinstorUtil.java 0.00% 12 Missing ⚠️
.../hypervisor/kvm/storage/LinstorStorageAdaptor.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #12300   +/-   ##
=========================================
  Coverage     16.23%   16.23%           
- Complexity    13371    13375    +4     
=========================================
  Files          5657     5657           
  Lines        498860   498869    +9     
  Branches      60543    60544    +1     
=========================================
+ Hits          81003    81006    +3     
- Misses       408824   408831    +7     
+ Partials       9033     9032    -1     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.09% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@rp- rp- force-pushed the linstor-4.20-use-dev-drbd-by-res branch from 629b483 to d499c33 Compare December 18, 2025 15:55
@rp-
Copy link
Contributor Author

rp- commented Dec 18, 2025

@DaanHoogland sorry I missed to locations.

@DaanHoogland
Copy link
Contributor

@DaanHoogland sorry I missed to locations.

but these are all?

@rp-
Copy link
Contributor Author

rp- commented Dec 18, 2025

@DaanHoogland sorry I missed to locations.

but these are all?

yes, all now

Instead of using the basic /dev/drbd1000 minor number block device path,
provide CloudStack with the actual resource path, that can also be linked
back to the CloudStack volume.path
@rp- rp- force-pushed the linstor-4.20-use-dev-drbd-by-res branch from d499c33 to 49d3e54 Compare December 19, 2025 11:49
@DaanHoogland DaanHoogland reopened this Dec 19, 2025
@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16110

@DaanHoogland
Copy link
Contributor

@abh1sar , is there any testing anybody but @rp- can do on this, or do we settle for gha? (I do not think smoke tests are touching anything relevant)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants