-
Notifications
You must be signed in to change notification settings - Fork 1.3k
linstor: Provide /dev/drbd/by-res/ resource paths to CloudStack #12300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12300 +/- ##
=========================================
Coverage 16.23% 16.23%
- Complexity 13371 13375 +4
=========================================
Files 5657 5657
Lines 498860 498869 +9
Branches 60543 60544 +1
=========================================
+ Hits 81003 81006 +3
- Misses 408824 408831 +7
+ Partials 9033 9032 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
629b483 to
d499c33
Compare
|
@DaanHoogland sorry I missed to locations. |
but these are all? |
yes, all now |
Instead of using the basic /dev/drbd1000 minor number block device path, provide CloudStack with the actual resource path, that can also be linked back to the CloudStack volume.path
d499c33 to
49d3e54
Compare
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16110 |
Description
Instead of providing the very basic
/dev/drbd{minorNr}drbd block device path provide theby-res path, that also includes the cloudstack volume.path
Prerequisite for #12218
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Spun up a fresh Linstor cluster, and checked the new path is used in the libvirt xml
How did you try to break this feature and the system with this change?