Allow copy of templates from secondary storages of same or other zone when adding a new secondary storage #611
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y added secondary storage
14 tasks
| | | when adding a new Secondary Storage, instead of downloading them from the source URL. | | | ||
| +----------------------------------------------+-------------------------------------------------------------------------------------------------------------+-----------+ | ||
|
|
||
| This setting is enabled by default and can be configured globally or at zone level. |
Contributor
There was a problem hiding this comment.
when creating a zone it is enabled by default, so preventing it will be hard right? A race against the machine.
Contributor
Author
There was a problem hiding this comment.
good point Daan. When creating a zone, it uses the global setting (not zone level). I also want to keep the default value to false to keep it backward compatible. But the first PR is already merged apache/cloudstack#10363, I can do that change in my subsequent PR apache/cloudstack#12296
One another point to note, if the setting is enabled, first it attempts to copy from secondary storage, if it fails then it fall back to old behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document is in relation to the PRs apache/cloudstack#10363 and apache/cloudstack#12296
📚 Documentation preview 📚: https://cloudstack-documentation--611.org.readthedocs.build/en/611/