GH-48588: [C++] use std::span #48615
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
WillAyd
requested changes
Dec 23, 2025
cpp/src/arrow/array/data.h
Outdated
| #include "arrow/util/bit_util.h" | ||
| #include "arrow/util/macros.h" | ||
| #include "arrow/util/span.h" | ||
| #include <span> |
Contributor
There was a problem hiding this comment.
Can you move the span include to be with the other stdlib headers, rather than down here with the arrow headers?
cpp/src/arrow/util/span_test.cc
Outdated
| static_assert(std::is_same_v<decltype(span(vec)), span<int>>); | ||
| static_assert(std::is_same_v<decltype(span(const_arr)), span<const int>>); | ||
| static_assert(std::is_same_v<decltype(span(const_vec)), span<const int>>); | ||
| static_assert(std::is_same_v<decltype(span(arr)), std::span<int>>); |
Contributor
There was a problem hiding this comment.
Suggested change
| static_assert(std::is_same_v<decltype(span(arr)), std::span<int>>); | |
| static_assert(std::is_same_v<decltype(std::span(arr)), std::span<int>>); |
Should these have the namespace too?
cpp/src/arrow/util/span_test.cc
Outdated
| using testing::PrintToString; | ||
|
|
||
| namespace arrow::util { | ||
| namespace arrow_util_span_test { |
Contributor
There was a problem hiding this comment.
Is this still required for other members?
Author
There was a problem hiding this comment.
No, i think this test file is no longer needed, so i will remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Replace custom
arrow::util::spanimplementation with C++20std::spanas suggested in issue #48588. This modernizes the codebase and removes ~130 lines of custom code.What changes are included in this PR?
src/arrow/util/span.h(custom span implementation)arrow::util::span<T>usage withstd::span<T>(95 occurrences)#include "arrow/util/span.h"to#include <span>(41 files)Are these changes tested?
Yes - created comprehensive tests verifying std::span compatibility with all original arrow::util::span functionality including construction, subspan, element access, and byte conversion.
Are there any user-facing changes?
No user-facing changes.