GH-48591: [C++] Use C++20 standard functions in bit_util.h #48611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This change replaces custom implementations of bit manipulation functions with C++20 standard library functions from the header. This will reduce the code complexity.
What changes are included in this PR?
Updated the
cpp/src/arrow/util/bit_util.hfile to replace the custom implementation forPopCount,CountLeadingZeros, andCountTrailingZeroswith C++20 standard library functionsstd::popcount(),std::countl_zero()andstd::countr_zero()respectively.Are these changes tested?
Yes
Are there any user-facing changes?
No, this is an internal refactoring of bit utility functions.