Skip to content

Conversation

@rok
Copy link
Member

@rok rok commented Dec 19, 2025

Rationale for this change

Switch to std::chrono for MSVC to be able to use the system-provided timezone automatically on Windows.

What changes are included in this PR?

This adds chrono_internal.h that uses C++20 std::chrono timezone/calendar APIs on compilers with support (MSVC only for now) and falls back to vendored date.h otherwise.

Are these changes tested?

Partially tested locally and partially to be tested on CI.

Are there any user-facing changes?

Yes, Windows users will no longer need to install the IANA tzdb (see instructions here and here). We possibly have tzdb download set up in CI too and should update it appropriately.

@github-actions
Copy link

⚠️ GitHub issue #48593 has been automatically assigned in GitHub to PR creator.

@rok rok force-pushed the cpp20_use_chrono branch 4 times, most recently from b52ebd1 to 4ea1a45 Compare December 20, 2025 00:00
@rok rok force-pushed the cpp20_use_chrono branch 2 times, most recently from 9af22a7 to d326360 Compare December 23, 2025 16:15
@rok rok force-pushed the cpp20_use_chrono branch from d326360 to e588444 Compare December 23, 2025 16:34
@rok rok force-pushed the cpp20_use_chrono branch from fb07f8a to 941f48e Compare December 23, 2025 17:31
@rok rok force-pushed the cpp20_use_chrono branch from 4283740 to d82f990 Compare December 23, 2025 18:14
@rok
Copy link
Member Author

rok commented Dec 23, 2025

It seems that std::chrono on GCC (14.3.0, 15.2.0) potentially has a bug that triggers some of our tests. Meanwhile std::chrono on MSVC 19.44 ( 14.44) appears to be pass them and is correct or at least consistent with vendored date.h. I would therefore advise we only switch to std::chrono on MSVC for now as that gives us the most benefit anyway (users no longer have to deal with the tz db).

Below is the explanation and reproduction of the bug.

// GCC libstdc++ DST bug reproduction
//
// The AN to AS Transition Bug
// ---------------------------
// Source https://github.com/eggert/tz/blob/c37fbc3249c1a1334948b38f3bca47dee5c11dd1/australasia#L165-L192
// Australia/Broken_Hill used the AN (New South Wales) rules until 2000, then
// switched to AS (South Australia) rules. Under AN rules, DST started the last
// Sunday of October and ended the last Sunday of March. For the 1999-2000
// summer, DST started October 31, 1999 and would end March 26, 2000. February
// 29, 2000 falls squarely within this DST period, so the correct offset should
// be 9:30 base + 1:00 DST = 10:30 (630 minutes).
//
// Why GCC's Data is Wrong
// -----------------------
// When libstdc++ processes the zone transition from AN rules to AS rules (which
// happens in year 2000), it appears to lose or reset the DST state inherited
// from the AN rules. Instead of recognizing that DST is still active from the
// October 1999 transition, it reports offset=570 (just the 9:30 base) with
// save=0. The inconsistency is evident: it returns abbrev="ACDT" (daylight
// time) but the offset and save values indicate standard time. The AN rules
// clearly show DST should be active until the last Sunday of March 2000.
//
// Compile: g++ -std=c++20 -o gcc_dst_bug gcc_libstdcxx_dst_bug.cpp
// Expected: 630 (10:30 = 9:30 base + 1:00 DST)
// Actual:   570 (9:30 = base only, DST missing)

#include <chrono>
#include <iostream>

int main() {
  using namespace std::chrono;
  auto* tz = locate_zone("Australia/Broken_Hill");
  auto info = tz->get_info(sys_days{2000y / February / 29d} + 23h + 23min + 23s);
  std::cout << duration_cast<minutes>(info.offset).count() << "\n";
}

@rok rok marked this pull request as ready for review December 23, 2025 18:46
@rok
Copy link
Member Author

rok commented Dec 23, 2025

@pitrou

@rok rok changed the title GH-48593: [Draft][C++] C++20: use standard calendar / timezone APIs GH-48593: [C++] C++20: use standard calendar / timezone APIs Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant