fix: display 0 secs for empty DayTime/MonthDayNano intervals
#9023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friendlymatthew
approved these changes
Dec 22, 2025
Contributor
friendlymatthew
left a comment
friendlymatthew
left a comment
There was a problem hiding this comment.
Wowza, very nice catch! Btw I think CI is hung?
Contributor
Author
CI failure seems unrelated, see #9024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
See #5914 (comment)
What changes are included in this PR?
If DayTime/MonthDayNano intervals are empty, write
0 secsfor display.Are these changes tested?
Updated existing tests.
Are there any user-facing changes?
Minor change in display behaviour (previously wrote out an empty string)