Skip to content

Conversation

@klion26
Copy link
Member

@klion26 klion26 commented Dec 12, 2025

Which issue does this PR close?

What changes are included in this PR?

Unify the CastOptions usage in parquet-variant-compute

Currently, there is only arrow::compute::CastOptions in parquet-variant-compute now, the existing parquet-variant-compute/CastOptions has replaced by the arrow::compute::CastOptions with the equal behavior

image

Are these changes tested?

The existing tests covered the logic

Are there any user-facing changes?

This will break some public API in parquet-variant-compute, but this crate is experiment now, so maybe we don't need to wait for a major release.

@github-actions github-actions bot added parquet Changes to the parquet crate parquet-variant parquet-variant* crates labels Dec 12, 2025
@klion26 klion26 force-pushed the unify_cast_in_variant branch 3 times, most recently from 07a7645 to 5c530ce Compare December 14, 2025 14:24
@github-actions github-actions bot removed the parquet Changes to the parquet crate label Dec 14, 2025
@klion26 klion26 marked this pull request as ready for review December 14, 2025 14:26
@klion26 klion26 force-pushed the unify_cast_in_variant branch from 5c530ce to 7abc92b Compare December 14, 2025 14:39
@klion26
Copy link
Member Author

klion26 commented Dec 15, 2025

@alamb this pr unified the usage of CastOptions for paruqet-variant-compute(will use arrow-cast/CastOptions), but it would break some public api in parquet-variant-compute, as parquet-variant-compute is experiment now, not sure if we need to wait for the next major version. If we need to wait for the next major version, I'll attach the api-change tag here.

@alamb alamb added the api-change Changes to the arrow API label Dec 15, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @klion26 -- this looks good to me

I agree it is an API change but since we have marked Variant as experimental we can still change it in a non-major release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Changes to the arrow API parquet-variant parquet-variant* crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Variant] Unify the cast option usage in ParquentVariant

2 participants