Skip to content

fix(@angular/build): conditionally manage Vitest UI option #32102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clydin wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −4
Open

fix(@angular/build): conditionally manage Vitest UI option #32102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/build/src/builders/unit-test/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export async function normalizeOptions(
browserViewport: width && height ? { width, height } : undefined,
watch,
debug: options.debug ?? false,
ui: options.ui ?? false,
ui: process.env['CI'] ? false : ui,
providersFile: options.providersFile && path.join(workspaceRoot, options.providersFile),
setupFiles: options.setupFiles
? options.setupFiles.map((setupFile) => path.join(workspaceRoot, setupFile))
Expand Down
2 changes: 1 addition & 1 deletion packages/angular/build/src/builders/unit-test/runners/vitest/executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ export class VitestExecutor implements TestExecutor {
cache: cacheOptions.enabled ? undefined : false,
testNamePattern: this.options.filter,
watch,
ui,
...(typeof ui === 'boolean' ? { ui } : {}),
...debugOptions,
},
{
Expand Down
3 changes: 1 addition & 2 deletions packages/angular/build/src/builders/unit-test/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,7 @@
},
"ui": {
"type": "boolean",
"description": "Enables the Vitest UI for interactive test execution. This option is only available for the Vitest runner.",
"default": false
"description": "Enables the Vitest UI for interactive test execution. This option is only available for the Vitest runner."
},
"coverage": {
"type": "boolean",
Expand Down