Skip to content

fix: use different umd variables #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kwliou wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use different umd variables #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/analytics-connector/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ const getCommonBrowserConfig = (target) => ({
replace({
preventAssignment: true,
BUILD_BROWSER: true,
define: '__amplitude__define__',
require: '__amplitude__require__',
}),
resolve(),
json(),
Expand Down
2 changes: 2 additions & 0 deletions packages/experiment-browser/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ const getCommonBrowserConfig = (target) => ({
replace({
preventAssignment: true,
BUILD_BROWSER: true,
define: '__amplitude__define__',
require: '__amplitude__require__',
}),
resolve(),
json(),
Expand Down
6 changes: 6 additions & 0 deletions packages/experiment-core/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { resolve as pathResolve } from 'path';
import babel from '@rollup/plugin-babel';
import commonjs from '@rollup/plugin-commonjs';
import resolve from '@rollup/plugin-node-resolve';
import replace from '@rollup/plugin-replace';
import typescript from '@rollup/plugin-typescript';

const getCommonBrowserConfig = (target) => ({
Expand All @@ -24,6 +25,11 @@ const getCommonBrowserConfig = (target) => ({
babelHelpers: 'bundled',
exclude: ['node_modules/**'],
}),
replace({
preventAssignment: true,
define: '__amplitude__define__',
require: '__amplitude__require__',
}),
],
});

Expand Down
8 changes: 7 additions & 1 deletion packages/experiment-tag/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import babel from '@rollup/plugin-babel';
import commonjs from '@rollup/plugin-commonjs';
import json from '@rollup/plugin-json';
import resolve from '@rollup/plugin-node-resolve';
import replace from '@rollup/plugin-replace';
import terser from '@rollup/plugin-terser';
import typescript from '@rollup/plugin-typescript';
import analyze from 'rollup-plugin-analyzer';
Expand Down Expand Up @@ -47,6 +48,11 @@ const getCommonBrowserConfig = (target) => ({
output: join(__dirname, 'dist', 'LICENSES'),
},
}),
replace({
preventAssignment: true,
define: '__amplitude__define__',
require: '__amplitude__require__',
}),
],
});

Expand All @@ -65,7 +71,7 @@ const configs = [
...config,
...getOutputConfig({
entryFileNames: 'experiment-tag-min.js',
format: 'iife',
format: 'umd',
}),
plugins: [
...config.plugins,
Expand Down
2 changes: 2 additions & 0 deletions packages/plugin-segment/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ const getCommonBrowserConfig = (target) => ({
replace({
preventAssignment: true,
BUILD_BROWSER: true,
define: '__amplitude__define__',
require: '__amplitude__require__',
}),
resolve(),
json(),
Expand Down