Skip to content

Take statsd host and port from environment if missing in the config. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
porridge wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Take statsd host and port from environment if missing in the config. #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/main/java/com/airbnb/kafka/kafka09/StatsdMetricsReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ public class StatsdMetricsReporter implements MetricsReporter {

private static final String METRIC_PREFIX = "kafka.";
private static final int POLLING_PERIOD_IN_SECONDS = 10;
private static final String STATSD_UDP_PORT = "STATSD_UDP_PORT";
private static final String STATSD_UDP_HOST = "STATSD_UDP_HOST";

private boolean enabled;
private final AtomicBoolean running = new AtomicBoolean(false);
Expand Down Expand Up @@ -119,14 +121,22 @@ public void close() {
stopReporter();
}

private String configSettingOrEnvVar(Map<String, ?> configs, String setting, String varName) {
if (configs.containsKey(setting)) {
return (String) configs.get(setting);
} else {
return System.getenv(varName);
}
}

@Override
public void configure(Map<String, ?> configs) {
enabled = configs.containsKey(STATSD_REPORTER_ENABLED) ?
Boolean.valueOf((String) configs.get(STATSD_REPORTER_ENABLED)) : false;
host = configs.containsKey(STATSD_HOST) ?
(String) configs.get(STATSD_HOST) : "localhost";
port = configs.containsKey(STATSD_PORT) ?
Integer.valueOf((String) configs.get(STATSD_PORT)) : 8125;
host = configSettingOrEnvVar(configs, STATSD_HOST, STATSD_UDP_HOST) != null ?
configSettingOrEnvVar(configs, STATSD_HOST, STATSD_UDP_HOST) : "localhost";
port = configSettingOrEnvVar(configs, STATSD_PORT, STATSD_UDP_PORT) != null ?
Integer.valueOf(configSettingOrEnvVar(configs, STATSD_PORT, STATSD_UDP_PORT)) : 8125;
prefix = configs.containsKey(STATSD_METRICS_PREFIX) ?
(String) configs.get(STATSD_METRICS_PREFIX) : "";
pollingPeriodInSeconds = configs.containsKey(POLLING_INTERVAL_SECS) ?
Expand Down