Skip to content

Conversation

@NamrathShetty
Copy link

No description provided.

Copilot AI review requested due to automatic review settings April 18, 2025 18:22
@NamrathShetty NamrathShetty requested a review from a team as a code owner April 18, 2025 18:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the actionUrl function to support a customizable base URI, enabling the function to handle GitHub Enterprise Server (GHES) scenarios. Key changes include:

  • Changing the actionUrl function signature to include a baseUri parameter.
  • Normalizing the baseUri to ensure it ends with a forward slash.
  • Removing the TODO comment now that the customization is implemented.
Comments suppressed due to low confidence (1)

languageservice/src/action.ts:70

  • [nitpick] Consider renaming 'gitHubBaseUri' to 'normalizedBaseUri' to clearly indicate that this variable represents a normalized version of the base URI.
const gitHubBaseUri = baseUri.endsWith("/") ? baseUri : `${baseUri}/`;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant