reading cache directory during runtime without dir crate #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markosg04
requested changes
Nov 23, 2025
src/lib.rs
Outdated
Comment on lines
113
to
115
| #[cfg(feature = "disk-persistence")] | ||
| pub use setup::get_storage_dir; | ||
|
|
Collaborator
There was a problem hiding this comment.
does this have to be re-exported / public api? If not then let's avoid that
src/setup.rs
Outdated
| #[cfg(feature = "disk-persistence")] | ||
| fn get_storage_dir() -> Option<PathBuf> { | ||
| dirs::cache_dir().map(|mut path| { | ||
| pub fn get_storage_dir() -> Option<PathBuf> { |
Collaborator
There was a problem hiding this comment.
we have two functions: get_storage_path and get_storage_dir. Since we are making changes here, is it possible to just make it one function?
tests/arkworks/setup.rs
Outdated
| if let Some(cache_dir) = dirs::cache_dir() { | ||
| if let Some(cache_dir) = get_storage_dir() { | ||
| let cache_file = cache_dir | ||
| .join("dory") |
Collaborator
There was a problem hiding this comment.
Suggested change
| .join("dory") |
This might be adding an extra /dory now that I am looking at it, which would silently fail to clean up
RadNi
force-pushed
the
amir/recursion-compile-bug
branch
3 times, most recently
from
e8df2f0 to
a098f89
Compare
Signed-off-by: Amirhossein Khajehpour <khajepour.amirhossein@gmail.com>
Signed-off-by: Amirhossein Khajehpour <khajepour.amirhossein@gmail.com>
RadNi
force-pushed
the
amir/recursion-compile-bug
branch
from
a098f89 to
4d3e0ab
Compare
markosg04
approved these changes
Nov 25, 2025
Collaborator
markosg04
left a comment
markosg04
left a comment
There was a problem hiding this comment.
Thanks a lot! Will merge this into the next release.
RadNi
force-pushed
the
amir/recursion-compile-bug
branch
from
d28dec9 to
e578dac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dir crate can not be compiled by the verifier in jolt which leads to proof recursion failure.
This PR removes dir dependency and manually determines caching directory.