Skip to content

Conversation

@blakeroberts-wk
Copy link
Contributor

Motivation

Changes

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Architecture member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@blakeroberts-wk
Copy link
Contributor Author

QA +1 manual testing, I was able to set a timeout in dart and have it applied to the this._timeout of a SockJS

@blakeroberts-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@btr-rmconsole-3 btr-rmconsole-3 bot merged commit a81fed5 into master May 21, 2025
2 checks passed
@btr-rmconsole-3 btr-rmconsole-3 bot deleted the add-timeout-option branch May 21, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants