feat: add support for wBnbBurnConverter #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gleiser-oliveira
force-pushed
the
feat/wbnb-burn-acc
branch
from
53b9530 to
7521c7e
Compare
gleiser-oliveira
force-pushed
the
feat/wbnb-burn-acc
branch
4 times, most recently
from
0c6d46e to
7bd6338
Compare
therealemjy
approved these changes
Jun 24, 2025
Comment on lines
+65
to
+68
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| export function handleInitializationWBnbBurnConverter(block: ethereum.Block): void { | ||
| getOrCreateTokenConverter(wBnbBurnConverterAddress); | ||
| } |
Member
There was a problem hiding this comment.
nit: since block is unused, you shouldn't need to define it at all.
Contributor
Author
There was a problem hiding this comment.
The function signature needs to match the template exactly, so the parameter needs to be declared even if unused
| return event; | ||
| }; | ||
|
|
||
| export const createCreateConvertedEvent = ( |
Member
There was a problem hiding this comment.
This looks like a duplicate of the createConvertedEvent function below.
chechu
reviewed
Jun 24, 2025
gleiser-oliveira
force-pushed
the
feat/wbnb-burn-acc
branch
from
7bd6338 to
8203895
Compare
chechu
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes