Minh/motorupdate #78
Open
Minh/motorupdate #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What did you use for pulling in etl? Did you use If you use |
Contributor
Author
|
I was trying to include the etl as a symlink from the etl in the common folder. But I guess on windows git bash just decided that's a straight copy |
Contributor
|
Ah okay, ideally if we're going all-in on CMake we should have a top-level CMakeLists.txt, and then we can export etl as a library once and it will get picket up in all projects. That's how we do it at work and it's quite nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to test Github Actions for building the motor controller