-
Notifications
You must be signed in to change notification settings - Fork 127
Allow updating robot gravity #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Allow updating robot gravity #415
Conversation
Signed-off-by: AdamPettinger <adam.l.pettinger@gmail.com>
Signed-off-by: AdamPettinger <adam.l.pettinger@gmail.com>
Signed-off-by: AdamPettinger <adam.l.pettinger@gmail.com>
Signed-off-by: AdamPettinger <adam.l.pettinger@gmail.com>
Signed-off-by: AdamPettinger <adam.l.pettinger@gmail.com>
|
Thank you for your contribution. Do you plan to change anything on this given that it's a draft? Doing a quick review the implementation seems fine, only some tests and documentation would be good. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #415 +/- ##
==========================================
- Coverage 43.15% 42.73% -0.42%
==========================================
Files 99 99
Lines 8660 8681 +21
Branches 1179 1182 +3
==========================================
- Hits 3737 3710 -27
- Misses 4644 4689 +45
- Partials 279 282 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Honestly, drafted all three of the related PRs because I haven't tested much with real hardware on Rolling (all the way with the I don't expect to run into troubles, and am willing to mark this ready for review if you are. I am trying to get around to testing the Rolling version on hardware by today or tomorrow. |
|
As I said, adding tests to https://github.com/UniversalRobots/Universal_Robots_Client_Library/blob/master/tests/test_script_command_interface.cpp and documentation to https://github.com/UniversalRobots/Universal_Robots_Client_Library/blob/master/doc/architecture/script_command_interface.rst would be needed to merge this. |
Signed-off-by: AdamPettinger <adam.l.pettinger@gmail.com>
I have a UR20 mounted on another robot that can change its orientation enough to cause problems for the arm's mounting installation.
These changes expose the
set_gravityURScript functionality through theClient Library, allowing a user to update the gravity vector of the robot during live operation. There is a corresponding PR onROS2_Driverthat further exposes this as a ROS service. This is obviously risky if you calculate the gravity vector incorrectly.