Skip to content

feat(ui5-multi-combobox): filtering selection enhancement #12799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StefanDimitrov04 wants to merge 3 commits into
base: main
Choose a base branch
from
+130 −0
Open

feat(ui5-multi-combobox): filtering selection enhancement #12799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f50bbc
feat(ui5-multi-combobox): filtering selection enhancement
StefanDimitrov04 Dec 12, 2025
c928e05
Merge branch 'main' into mcb-mf
StefanDimitrov04 Dec 12, 2025
b6298e4
Remove debug log from MultiComboBox
StefanDimitrov04 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 124 additions & 0 deletions packages/main/cypress/specs/MultiComboBox.mobile.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,130 @@ describe("Items selection", () => {
.find<ResponsivePopover>("[ui5-responsive-popover]")
.ui5ResponsivePopoverOpened();
});

it("Should disable the toggle button when there are no selected items", () => {
cy.mount(
<MultiComboBox>
<MultiComboBoxItem text="Cosy"></MultiComboBoxItem>
<MultiComboBoxItem text="Compact"></MultiComboBoxItem>
</MultiComboBox>
);

cy.get("[ui5-multi-combobox]")
.realClick();

cy.get("[ui5-multi-combobox]")
.shadow()
.find<ResponsivePopover>("[ui5-responsive-popover]")
.as("respPopover")
.ui5ResponsivePopoverOpened();

cy.get("@respPopover")
.find("[ui5-toggle-button]")
.should("have.attr", "disabled");
});

it("Should enable the toggle button when there is selected item", () => {
cy.mount(
<MultiComboBox>
<MultiComboBoxItem text="Cosy" selected></MultiComboBoxItem>
<MultiComboBoxItem text="Compact"></MultiComboBoxItem>
</MultiComboBox>
);

cy.get("[ui5-multi-combobox]")
.realClick();

cy.get("[ui5-multi-combobox]")
.shadow()
.find<ResponsivePopover>("[ui5-responsive-popover]")
.as("respPopover")
.ui5ResponsivePopoverOpened();

cy.get("@respPopover")
.find("[ui5-toggle-button]")
.should("not.have.attr", "disabled");
});

it("Should show only selected items on n-more click and toggle the button", () => {
cy.mount(
<MultiComboBox placeholder="Select options">
<MultiComboBoxItem text="Item 1" selected />
<MultiComboBoxItem text="Item 2" selected />
<MultiComboBoxItem text="Item 3" />
<MultiComboBoxItem text="Item 4" selected />
</MultiComboBox>
);

cy.get("[ui5-multi-combobox]")
.shadow()
.find("[ui5-tokenizer]")
.shadow()
.find(".ui5-tokenizer-more-text")
.realClick();

cy.get("[ui5-multi-combobox]")
.shadow()
.find<ResponsivePopover>("[ui5-responsive-popover]")
.as("respPopover")
.ui5ResponsivePopoverOpened();

cy.get("@respPopover")
.find("[ui5-toggle-button]")
.should("have.attr", "pressed");

cy.get("@respPopover")
.find("[ui5-list]")
.find("slot")
.should("have.length", 3);
});

it("Shows all items matching 'I' after clicking N-more and typing in the popover input", () => {
cy.mount(
<MultiComboBox placeholder="Select options">
<MultiComboBoxItem text="Item 1" selected />
<MultiComboBoxItem text="Item 2" />
<MultiComboBoxItem text="Item 3" />
<MultiComboBoxItem text="Item 4" selected />
</MultiComboBox>
);

cy.get("[ui5-multi-combobox]")
.shadow()
.find("[ui5-tokenizer]")
.shadow()
.find(".ui5-tokenizer-more-text")
.realClick();

cy.get("[ui5-multi-combobox]")
.shadow()
.find<ResponsivePopover>("[ui5-responsive-popover]")
.as("respPopover")
.ui5ResponsivePopoverOpened();

cy.get("@respPopover")
.find("[ui5-toggle-button]")
.should("have.attr", "pressed");

cy.get("@respPopover")
.find("[ui5-list]")
.find("slot")
.should("have.length", 2);

cy.get("@respPopover")
.find("[ui5-input]")
.realClick()
.realType("I");

cy.get("@respPopover")
.find("[ui5-toggle-button]")
.should("not.have.attr", "pressed");

cy.get("@respPopover")
.find("[ui5-list]")
.find("slot")
.should("have.length", 4);
});
});

describe("Value state header", () => {
Expand Down
5 changes: 5 additions & 0 deletions packages/main/src/MultiComboBox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,10 @@ class MultiComboBox extends UI5Element implements IFormInputElement {
this._dialogInputValueState = this.valueState;
}

if (this.filterSelected) {
this.filterSelected = false;
}

this.value = value;
this._shouldFilterItems = true;
this.valueBeforeAutoComplete = value;
Expand All @@ -646,6 +650,7 @@ class MultiComboBox extends UI5Element implements IFormInputElement {
if (!isEnter(e)) {
return;
}

const { value } = (e.target as Input);
const matchingItem = this._getItems().find(item => item.text === value);

Expand Down
1 change: 1 addition & 0 deletions packages/main/src/MultiComboBoxPopoverTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export default function MultiComboBoxPopoverTemplate(this: MultiComboBox) {
icon={multiSelectAll}
design="Transparent"
pressed={this._showAllItemsButtonPressed}
disabled={this._getSelectedItems().length === 0}
onClick={this.filterSelectedItems}
accessibleName={this._showSelectedButtonAccessibleNameText}
></ToggleButton>
Expand Down
Loading