feat(ui5-calendar): improve header and day picker accessibility and focus behavior #12712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🚀 Deployed on https://pr-12712--ui5-webcomponents-preview.netlify.app |
GDamyanov
changed the title
unazko
reviewed
Dec 15, 2025
Contributor
unazko
left a comment
unazko
left a comment
There was a problem hiding this comment.
Overall the code is clean.
I've found the following behavioural issue:
- Right mouse click triggers the previous/next button's action
unazko
reviewed
Dec 16, 2025
unazko
approved these changes
Dec 17, 2025
Contributor
unazko
left a comment
unazko
left a comment
There was a problem hiding this comment.
The code looks good to me.
Tested with the accessibility manually with screen reader and AMP tool.
Everything works fine.
tsanislavgatev
requested changes
Dec 17, 2025
|
|
||
| cy.focused().realPress(["Shift", "F4"]); | ||
|
|
||
| .find("[tabindex='0']") | ||
| .should("have.focus"); | ||
|
|
||
| cy.get("@selectedDays").each(($day, index) => { | ||
| cy.wrap($day).should("have.attr", "aria-label"); | ||
|
|
||
|
|
||
| describe("Day Picker Tests", () => { | ||
| it.skip("Select day with Space", () => { | ||
| it.skip("Select day with Space", () => { |
| it.skip("Select day with Space", () => { | ||
| cy.mount(<Calendar id="calendar1"></Calendar>); | ||
|
|
||
| expect(selectedDate).to.eq(expectedDate); | ||
| }); | ||
|
|
||
|
|
||
| cy.mount(<Calendar id="calendar1"></Calendar>); | ||
|
|
||
| it("Day names are correctly displayed", () => { | ||
| cy.mount(<Calendar id="calendar1"></Calendar>); | ||
|
|
||
| const todayFromTimestamp = new Date(timestamp * 1000); | ||
| const actualToday = new Date(); | ||
|
|
||
packages/main/src/Calendar.ts
Outdated
| _pickersMode: `${CalendarPickersMode}` = "DAY_MONTH_YEAR"; | ||
|
|
||
| @property({ type: Boolean, noAttribute: true }) | ||
| _isOpenedFromPopover?: boolean = false; |
Contributor
There was a problem hiding this comment.
what does this mean?
tsanislavgatev
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.