Skip to content

fix(syntax): remove aggressive python type inference rules #6274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikhil2004-blip wants to merge 1 commit into from
+16 −16
Closed

fix(syntax): remove aggressive python type inference rules #6274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions src/textual/tree-sitter/highlights/python.scm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@
(interpolation) @none

;; Identifier naming conventions
((identifier) @type
(#match? @type "^[A-Z].*[a-z]"))
((identifier) @constant
(#match? @constant "^[A-Z][A-Z_0-9]*$"))
Comment on lines 12 to -16
Copy link
Collaborator

@TomJGooding TomJGooding Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows naming conventions as mentioned in the comment above.

Here's a simple example of variables with different casings in Python:

score = 999
Score = 999
SCORE = 999

Notice the syntax highlighting on GitHub and the screenshot below from Neovim:

image


((attribute
attribute: (identifier) @field)
(#match? @field "^([A-Z])@!.*$"))
;; ((identifier) @type
;; (#match? @type "^[A-Z].*[a-z]"))
;; ((identifier) @constant
;; (#match? @constant "^[A-Z][A-Z_0-9]*$"))
;;
;; ((attribute
;; attribute: (identifier) @field)
;; (#match? @field "^([A-Z])@!.*$"))

((identifier) @type.builtin
(#any-of? @type.builtin
Expand Down Expand Up @@ -57,14 +57,14 @@
function: (attribute
attribute: (identifier) @method.call))

((call
function: (identifier) @constructor)
(#match? @constructor "^[A-Z]"))

((call
function: (attribute
attribute: (identifier) @constructor))
(#match? @constructor "^[A-Z]"))
;; ((call
;; function: (identifier) @constructor)
;; (#match? @constructor "^[A-Z]"))
;;
;; ((call
;; function: (attribute
;; attribute: (identifier) @constructor))
;; (#match? @constructor "^[A-Z]"))

;; Decorators

Expand Down