Fix: Remove NodeJS dependency for get-virtual-routes.ts #3267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Currently the file
packages/hydrogen/src/vite/get-virtual-routes.tsuses NodeJS specific functions to get the virtual routes (graphiql, subrequest profiler, etc).When the
hydrogenRoutesfunction is called during the Hydrogen build process if the current execution environment is in Mini-Oxygen or Cloudflare an error is thrown which prevents the build from succeedingWHAT is this pull request doing?
Removes
getVirtualRoutesfromget-virtual-routes.ts(this function isn't used anywhere)Removes all NodeJS imports from
get-virtual-routes.tsRemoves unit test for
getVirtualRoutesHOW to test your changes?
Verify unit test
packages/hydrogen/src/vite/get-virtual-routes.test.tsis passingI have a test npm package with these changes you can add this package as a depedency like below:
in a test hydrogen react router 7 project.
Verify
shopify hydrogen NODE_ENV=development shopify hydrogen dev --codegenbuilds successfullyVerify
NODE_ENV=test npm run build && shopify hydrogen previewbuilds successfullyChecklist