All changes to pre-existing recipes #3205
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 25, 2025
Draft
kdaviduik
force-pushed
the
graphite-base/3205
branch
from
4a58da5 to
d9de928
Compare
5 tasks
rbshop
reviewed
Sep 26, 2025
rbshop
reviewed
Sep 26, 2025
| #### File: /app/routes/collections.$handle.tsx | ||
|
|
||
| ```diff | ||
| @@ -4,7 +4,10 @@ import {getPaginationVariables, Analytics} from '@shopify/hydrogen'; |
Contributor
There was a problem hiding this comment.
Again, these deletions look unintentional...
rbshop
reviewed
Sep 26, 2025
| productOptions={productOptions} | ||
| - selectedVariant={selectedVariant} | ||
| + selectedVariant={combinedListing ? selectedVariant : undefined} | ||
| + selectedVariant={combinedListing ? undefined : selectedVariant} |
rbshop
reviewed
Sep 26, 2025
| 3. On the [Products](https://admin.shopify.com/products) page, open any products that will be sold as subscriptions and add the relevant subscription plans in the **Purchase options** section. | ||
| The Hydrogen demo storefront comes pre-configured with an example subscription product with the handle `shopify-wax`. | ||
|
|
||
| ### Step 1: app/components/CartLineItem.tsx |
Contributor
There was a problem hiding this comment.
Not sure what happened here, but this wasn't meant to be step 1 (step 1 already exists above). It was originally step 3.2. The code diff doesn't appear to have changed though
rbshop
reviewed
Sep 26, 2025
| precision | ||
| } | ||
| } | ||
| fragment SubscriptionDiscountFragment on SubscriptionDiscount { |
Contributor
There was a problem hiding this comment.
This was lost but all since restored
rbshop
reviewed
Sep 26, 2025
| export default function Collection() { | ||
| const {collection} = useLoaderData<typeof loader>(); | ||
|
|
||
| + // Manually filter out combined listings from the collection products, because filtering |
Contributor
There was a problem hiding this comment.
Yeah this was definitely unintentional I'd say
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist