[Feature] Include Request ID at the footer of shopify theme * command errors
#6736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This will improve our relationship with the community, as we frequently need to deal with the back and forth of asking for the --verbose output.
Fixes https://github.com/Shopify/developer-tools-team/issues/467
WHAT is this pull request doing?
We make use of the
catchmethod inCommandto append the graphql request id made if present. It only affectsThemeCommandand leaves other parts of the cli untouched.How to test your changes?
Besides running the written unit tests, you may:
pnpm shopify theme pull --store <VALID_STORE_ID>.myshopify.com --theme 999999999for an error with a request idpnpm shopify theme list --store fake-store-that-does-not-exist.myshopify.comfor an error without a request id (it fails during auth)Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist