Fix ActionViewExtension not available during eager loading #727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MoneyRails::ActionViewExtensionnot being available during eager loading (config.eager_load = true)autoloadto define the constant immediately at require time, deferring file loading until first accessProblem
When a Rails app has
config.eager_load = true(production), referencingMoneyRails::ActionViewExtensionraises:This happens because the extension is only loaded inside an
ActiveSupport.on_load(:action_view)callback. During eager loading, app files (like decorators) thatinclude MoneyRails::ActionViewExtensionare loaded before ActionView triggers the callback.Solution
Use
autoloadto register the constant immediately while deferring the actual file load:The
on_load(:action_view)callback still includes the helper intoActionView::Base, but no longer needs to handle the require.Test plan
MoneyRails::ActionViewExtensionin an app withconfig.eager_load = trueFixes #614