-
Notifications
You must be signed in to change notification settings - Fork 9
Replace pkg_resources and bump Python version requirements #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
brian-rose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that I understand everything that's going on here, but it's passing CI and I don't see anything amiss.
|
|
Ah, right. And it looks like the Python versions on here are quite old at this point. I'll put this in draft for now since it probably makes more sense to merge after those changes. |
@dcamron, I think the changes I just pushed should cover the key pieces here (i.e. Python versions and associated metadata) and a few minor things I caught along the way. Let me know if not. I realize there's more that could be done re: packaging updates, but I think those can probably come later. |
jukent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how much we are using this repo, could someone link me to if we use these datasets in Cookbooks or Foundations?
We use them in Foundations, e.g. here. I'm not sure if any cookbooks are using it. I think we decided at some point that the explicit scope of the package is to serve example data for Foundations but shouldn't grow beyond that. This is laid out in the README, e.g. https://github.com/ProjectPythia/pythia-datasets?tab=readme-ov-file#adding-new-datasets |
I don't know about other repos, but Foundations uses it in a few sections: |
Replaces the use of now deprecated pkg_resources.
Closes #200