Skip to content

Conversation

@kafitzgerald
Copy link
Contributor

Replaces the use of now deprecated pkg_resources.

Closes #200

@kafitzgerald kafitzgerald requested review from a team, brian-rose and dcamron and removed request for a team July 29, 2025 16:11
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that I understand everything that's going on here, but it's passing CI and I don't see anything amiss.

@dcamron
Copy link

dcamron commented Aug 4, 2025

importlib.resources.files was added in Python 3.9. I think that's a fine minimum Python to support moving forward, but we need to do more packaging cleanup before a release.

@kafitzgerald
Copy link
Contributor Author

importlib.resources.files was added in Python 3.9. I think that's a fine minimum Python to support moving forward, but we need to do more packaging cleanup before a release.

Ah, right. And it looks like the Python versions on here are quite old at this point.

I'll put this in draft for now since it probably makes more sense to merge after those changes.

@kafitzgerald kafitzgerald marked this pull request as draft August 5, 2025 13:40
@kafitzgerald kafitzgerald marked this pull request as ready for review November 12, 2025 01:43
@kafitzgerald
Copy link
Contributor Author

importlib.resources.files was added in Python 3.9. I think that's a fine minimum Python to support moving forward, but we need to do more packaging cleanup before a release.

@dcamron, I think the changes I just pushed should cover the key pieces here (i.e. Python versions and associated metadata) and a few minor things I caught along the way. Let me know if not.

I realize there's more that could be done re: packaging updates, but I think those can probably come later.

@kafitzgerald kafitzgerald changed the title Replace pkg_resources Replace pkg_resources and bump Python version requirements Nov 12, 2025
Copy link
Contributor

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how much we are using this repo, could someone link me to if we use these datasets in Cookbooks or Foundations?

@brian-rose
Copy link
Member

brian-rose commented Dec 9, 2025

I'm not sure how much we are using this repo, could someone link me to if we use these datasets in Cookbooks or Foundations?

We use them in Foundations, e.g. here. I'm not sure if any cookbooks are using it. I think we decided at some point that the explicit scope of the package is to serve example data for Foundations but shouldn't grow beyond that.

This is laid out in the README, e.g. https://github.com/ProjectPythia/pythia-datasets?tab=readme-ov-file#adding-new-datasets

@kafitzgerald
Copy link
Contributor Author

I'm not sure how much we are using this repo, could someone link me to if we use these datasets in Cookbooks or Foundations?

I don't know about other repos, but Foundations uses it in a few sections:
https://github.com/search?q=repo%3AProjectPythia%2Fpythia-foundations%20pythia_datasets&type=code

@jukent jukent merged commit 5e8f9b9 into ProjectPythia:main Dec 9, 2025
7 checks passed
@kafitzgerald kafitzgerald deleted the remove_pkg_resources branch December 10, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use of deprecated pkg_resources

4 participants