Skip to content

Conversation

@luancazarine
Copy link
Collaborator

@luancazarine luancazarine commented Dec 18, 2025

Resolves #19488

Summary by CodeRabbit

  • Bug Fixes

    • Updated response details endpoint to use the correct /details API path.
  • Documentation

    • Updated the response action's docs link to point to the correct SurveyMonkey docs.
  • Chores

    • Bumped component package version to 0.0.5 and locked platform dependency.
    • Incremented version metadata across multiple actions and sources for consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@luancazarine luancazarine linked an issue Dec 18, 2025 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Dec 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
pipedream-docs-redirect-do-not-edit Ignored Ignored Dec 18, 2025 8:49pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

Walkthrough

Updated SurveyMonkey component: switched the response retrieval endpoint to the /details path, bumped versions for multiple actions and sources, and pinned the package dependency while bumping the package version.

Changes

Cohort / File(s) Summary
API endpoint change
components/survey_monkey/survey_monkey.app.mjs
getResponseDetails({ surveyId, responseId, ... }) now calls /surveys/${surveyId}/responses/${responseId}/details (path changed).
Action: get-response version bump
components/survey_monkey/actions/get-response/get-response.mjs
Exported version updated 0.0.20.1.0; description URL updated to SurveyMonkey response details docs.
Action version bumps (grouped)
components/survey_monkey/actions/find-survey/find-survey.mjs, components/survey_monkey/actions/get-collector/get-collector.mjs, components/survey_monkey/actions/get-my-info/get-my-info.mjs, components/survey_monkey/actions/list-collectors/list-collectors.mjs, components/survey_monkey/actions/list-responses/list-responses.mjs, components/survey_monkey/actions/list-surveys/list-surveys.mjs
Incremented exported version fields (patch/minor bumps) with no logic changes.
Source version bumps (grouped)
components/survey_monkey/sources/custom-webhook-events/custom-webhook-events.mjs, components/survey_monkey/sources/new-survey-response/new-survey-response.mjs, components/survey_monkey/sources/new-survey/new-survey.mjs
Incremented exported version fields (patch bumps) with no logic changes.
Package manifest
components/survey_monkey/package.json
Bumped package version 0.0.40.0.5; changed dependency @pipedream/platform from ^0.10.13.1.1.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Review focus:
    • components/survey_monkey/survey_monkey.app.mjs — confirm the new /details path returns the expected response payload shape and that callers/actions parse fields correctly.
    • components/survey_monkey/actions/get-response/get-response.mjs — ensure the description/version bump matches the functional change and metadata is consistent.
    • components/survey_monkey/package.json — verify the pinned @pipedream/platform version is intentional and compatible with the component code.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description only contains 'Resolves #19488' and does not follow the required template structure with a 'WHY' section explaining the motivation. Complete the pull request description by filling in the 'WHY' section to explain the purpose and impact of the changes.
Out of Scope Changes check ⚠️ Warning Most changes are focused on the linked issue requirement, but the package.json dependency pinning from '^0.10.1' to '3.1.1' appears unrelated to the response details endpoint fix. Clarify the rationale for pinning @pipedream/platform to version 3.1.1 or revert if unrelated to the endpoint fix.
Title check ❓ Inconclusive The title '19488 surveymonkey' is vague and does not clearly summarize the main change; it appears to be a reference to an issue number rather than a descriptive summary. Use a descriptive title that summarizes the main change, such as 'Fix getResponseDetails endpoint to include full answers' or 'Update SurveyMonkey response details endpoint'.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes successfully address the core requirement: the getResponseDetails method now uses the /details endpoint to retrieve full response answers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 19488-surveymonkey

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9e071de and 95504c2.

📒 Files selected for processing (1)
  • components/survey_monkey/actions/get-response/get-response.mjs (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-07-04T18:11:59.822Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.

Applied to files:

  • components/survey_monkey/actions/get-response/get-response.mjs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Lint Code Base
  • GitHub Check: Verify TypeScript components
  • GitHub Check: Publish TypeScript components
  • GitHub Check: pnpm publish
🔇 Additional comments (2)
components/survey_monkey/actions/get-response/get-response.mjs (2)

9-9: Documentation URL correctly updated.

The documentation URL now properly references the /details endpoint, addressing the previous review comment. This aligns with the correct API endpoint being used to retrieve full response answers.


10-10: Version bump is appropriate.

The minor version bump from 0.0.2 to 0.1.0 correctly reflects the functional improvement to retrieve full response answers.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 67eaf60 and a7f6507.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • components/survey_monkey/actions/get-response/get-response.mjs (1 hunks)
  • components/survey_monkey/package.json (2 hunks)
  • components/survey_monkey/survey_monkey.app.mjs (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.

Applied to files:

  • components/survey_monkey/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: pnpm publish
  • GitHub Check: Verify TypeScript components
  • GitHub Check: Lint Code Base
  • GitHub Check: Publish TypeScript components
🔇 Additional comments (3)
components/survey_monkey/actions/get-response/get-response.mjs (1)

10-10: Version bump looks appropriate.

The minor version increment from 0.0.2 to 0.1.0 correctly reflects a bug fix that changes behavior (now returning full response details).

components/survey_monkey/package.json (1)

3-3: Package version bump is consistent with the fix.

The patch version increment from 0.0.4 to 0.0.5 appropriately reflects a bug fix.

components/survey_monkey/survey_monkey.app.mjs (1)

166-174: Endpoint correction successfully addresses the reported issue.

The addition of /details to the response endpoint path is correct and directly resolves issue #19488. This change:

  • Aligns with the SurveyMonkey API documentation for retrieving full response details
  • Follows the same pattern as getSurveyDetails (line 153) which uses /surveys/${surveyId}/details
  • Ensures full response answers are returned instead of partial data

The method signature remains unchanged, maintaining backward compatibility for the caller.

Copy link
Collaborator

@michelle0927 michelle0927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Surveymonkey

3 participants