-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add Aircall action to retrieve call transcription #19509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Aircall action to retrieve call transcription #19509
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
|
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
WalkthroughAdds a new Aircall action to retrieve AI-generated call transcriptions and a corresponding Changes
Sequence Diagram(s)sequenceDiagram
participant Runner as Action Runner
participant App as Aircall App Adapter
participant API as Aircall API
Runner->>App: retrieveTranscription(callId, $)
App->>API: GET /v1/calls/{callId}/transcription
API-->>App: 200 OK (transcription payload)
App-->>Runner: transcription object
Runner->>Runner: exportSummary(transcription.id)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lcaresia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
components/aircall/actions/retrieve-transcription/retrieve-transcription.mjs
Outdated
Show resolved
Hide resolved
components/aircall/actions/retrieve-transcription/retrieve-transcription.mjs
Outdated
Show resolved
Hide resolved
components/aircall/actions/retrieve-transcription/retrieve-transcription.mjs
Outdated
Show resolved
Hide resolved
components/aircall/actions/retrieve-transcription/retrieve-transcription.mjs
Outdated
Show resolved
Hide resolved
refactor(aircall): align retrieve transcription action with app conventions Co-authored-by: Lucas Caresia <lucascarezia@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
components/aircall/actions/retrieve-transcription/retrieve-transcription.mjs(1 hunks)
🔇 Additional comments (3)
components/aircall/actions/retrieve-transcription/retrieve-transcription.mjs (3)
1-2: LGTM: Import follows Pipedream conventions.The import statement correctly references the Aircall app module using the appropriate relative path for the action's location in the directory structure.
3-22: LGTM: Component structure follows Pipedream guidelines.The component metadata, annotations, and props are well-defined:
- The key follows the required pattern (
aircall-retrieve-transcription)- Annotations correctly indicate this is a non-destructive, read-only action
- Props structure properly references the app and uses
propDefinitionfor the call parameter
23-29: Verify that the Aircall API transcription response includes anidfield.Line 26 uses
transcription.idin the summary message, but the Aircall transcription API response schema is not documented in this codebase. Confirm with Aircall's API documentation or test data that the response includes anidfield; otherwise, the summary will displayundefined.
|
|
||
| export default { | ||
| name: "Retrieve Transcription", | ||
| description: "Retrieves AI-generated transcription for a specific Aircall call. [See the docs here](https://developer.aircall.io/api-references/#retrieve-a-transcription)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Consider documenting the AI Assist prerequisite.
The PR objectives note that "AI Assist add-on must be enabled on the Aircall account" for this feature to work. Consider adding this requirement to the description to help users understand prerequisites upfront.
🔎 Suggested description enhancement:
- description: "Retrieves AI-generated transcription for a specific Aircall call. [See the docs here](https://developer.aircall.io/api-references/#retrieve-a-transcription)",
+ description: "Retrieves AI-generated transcription for a specific Aircall call. Requires the AI Assist add-on to be enabled on your Aircall account. [See the docs here](https://developer.aircall.io/api-references/#retrieve-a-transcription)",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| description: "Retrieves AI-generated transcription for a specific Aircall call. [See the docs here](https://developer.aircall.io/api-references/#retrieve-a-transcription)", | |
| description: "Retrieves AI-generated transcription for a specific Aircall call. Requires the AI Assist add-on to be enabled on your Aircall account. [See the docs here](https://developer.aircall.io/api-references/#retrieve-a-transcription)", |
🤖 Prompt for AI Agents
In components/aircall/actions/retrieve-transcription/retrieve-transcription.mjs
around line 5, the action description omits the prerequisite that the Aircall
account must have the AI Assist add-on enabled; update the description string to
explicitly state that AI Assist must be enabled on the Aircall account for this
feature to work, phrasing it succinctly (e.g., append "Requires the Aircall AI
Assist add-on to be enabled on the account.") and keep the existing docs link
intact.
|
Hi everyone, all test cases are passed! Ready for release! Test reports
|
WHY
Fixes #19508
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.