-
Notifications
You must be signed in to change notification settings - Fork 95
[Vault] Simplify VaultCore. #2714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clement-ux
wants to merge
54
commits into
master
Choose a base branch
from
clement/simplify-ousd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove WETH dependencies
…implify total value calculations
… and clean up comments in VaultCore
…ctions, simplifying the codebase.
…implify the codebase.
… improve clarity by removing deprecated functions and updating asset handling methods.
…itialization by using address(0) for backing asset.
…move deprecated asset handling
…rategy handling for backing asset
…address, simplifying price retrieval and enhancing clarity
…nstructors for improved clarity and functionality
…ved clarity and consistency
…y by removing unused variables and consolidating test cases
…nd consolidating test cases
…d consolidating test cases
…ables and consolidating test cases
…ate mint and redeem amounts for consistency
…fy asset handling
…et address, update test fixtures to use USDC instead of USDS, and simplify Dripper and VaultValueChecker tests by removing unused variables and consolidating logic.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2714 +/- ##
==========================================
- Coverage 41.10% 35.44% -5.66%
==========================================
Files 126 128 +2
Lines 5778 5504 -274
Branches 1537 1463 -74
==========================================
- Hits 2375 1951 -424
- Misses 3401 3552 +151
+ Partials 2 1 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ltInitializer, and VaultStorage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes substantial changes to the
IVaultinterface and related contracts, primarily to simplify asset and strategy management, remove unused or deprecated functionality, and update how price oracles are referenced. The changes affect core vault logic, mock contracts, strategies, and event emissions. The most important changes are grouped by theme below.Vault Interface Simplification and Refactoring
IVault, including asset-specific strategy management, swapper/oracle slippage controls, and price provider references, to streamline the interface. This includes the removal ofpriceProvider,setPriceProvider, swap-related functions, and asset-specific strategy functions. [1] [2] [3] [4] [5] [6] [7]setDefaultStrategy,defaultStrategy, andDefaultStrategyUpdated. [1] [2]backingAsset()as a public view function.weth()to the end of the interface and ensured it is still accessible.Oracle and Price Provider Handling
BridgedWOETHStrategyand mocks). [1] [2] [3] [4] [5] [6] [7] [8]IVault.priceProvider(). [1] [2] [3] [4] [5] [6]Asset and Strategy Management
backingAssetinstead of asset arrays or indices, and simplified asset support logic. [1] [2] [3] [4] [5]Miscellaneous Updates
OETHVaultcontract.These changes significantly modernize and simplify the vault and strategy interfaces, improve clarity, and reduce unused code, paving the way for easier maintenance and future upgrades.
These changes help reduce contract complexity, remove unused features, and prepare the codebase for future upgrades.
Code Change Checklist
To be completed before internal review begins:
Internal review:
Deploy checklist
Two reviewers complete the following checklist: