Reorg Rewind optimisation #231
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add remained latest tests
LeoPatOZ
commented
Dec 5, 2025
| /// | ||
| /// The `common_ancestor_block` field contains the block number of the last block | ||
| /// that is still valid on the canonical chain. | ||
| ReorgDetected { common_ancestor_block: u64 }, |
Collaborator
Author
There was a problem hiding this comment.
maybe we can find a more succinct name
LeoPatOZ
commented
Dec 5, 2025
Comment on lines
+18
to
+21
| scanner.start().await?; | ||
|
|
||
| // Trigger a reorg that removes the last 2 blocks (events 19 and 20) | ||
| provider.primary().anvil_reorg(ReorgOptions { depth: 2, tx_block_pairs: vec![] }).await?; |
Collaborator
Author
There was a problem hiding this comment.
This is inherently flaky as reorg may complete after scanner finishes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #198
Changes: