[ModelicaSystem] remove dependency on depreciated OMCSessionZMQ #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntron
force-pushed
the
OMCSession_new
branch
from
5ad32fd to
3ccb5fd
Compare
syntron
changed the title
Member
|
Please rebase. |
syntron
force-pushed
the
OMCSession_new
branch
from
3ccb5fd to
fe7acf1
Compare
Contributor
Author
Done ... |
adeas31
requested changes
Dec 17, 2025
|
|
||
|
|
||
| def test_isPackage(): | ||
| omczmq = OMPython.OMCSessionZMQ() |
Member
There was a problem hiding this comment.
Why is this test still using OMCSessionZMQ?
I understand that OMCSessionZMQ is still in code with depreciation warning but the test should use the latest code.
github-project-automation
bot
moved this from Backlog
to In review
in OMPython Release 5.0.0 plan
adeas31
approved these changes
Dec 17, 2025
github-project-automation
bot
moved this from In review
to Ready
in OMPython Release 5.0.0 plan
github-project-automation
bot
moved this from Ready
to Done
in OMPython Release 5.0.0 plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on top of PR #384
remove dependencies on the depreciated OMCSessionZMQ; it is replaced by OMCSession(Local|Port|Docker|DockerContainer|WSL)