-
Notifications
You must be signed in to change notification settings - Fork 65
Assertion messages in error messages #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SengerM
wants to merge
3
commits into
OpenModelica:master
Choose a base branch
from
SengerM:assertion-handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Probably its easier to directly add the example in the tests and check against the expected output. |
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Nov 4, 2025
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Nov 5, 2025
'from ex' links the original exception but this is not always shown see also OpenModelica#328
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Nov 5, 2025
'from ex' links the original exception but this is not always shown see also OpenModelica#328
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Nov 6, 2025
'from ex' links the original exception but this is not always shown see also OpenModelica#328
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Nov 13, 2025
'from ex' links the original exception but this is not always shown see also OpenModelica#328
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Nov 14, 2025
'from ex' links the original exception but this is not always shown see also OpenModelica#328
adeas31
added a commit
that referenced
this pull request
Nov 17, 2025
'from ex' links the original exception but this is not always shown see also #328 Co-authored-by: Adeel Asghar <adeel.asghar@liu.se>
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make assertion messages defined in Modelica models visible in Python error messages.
Approach
The current implementation completely hides away assertion messages, which makes it very hard to debug when something is not working. This simple change shows the user what the assertion error was (see below), though I recognize it is not the most beautiful so it might be improved.
Additionally, I added a simple example to illustrate how to use assertions in Modelica. This is the output that the user gets when the example is run:
Finally, a prototype of
test_passingfunction that could be made a standard with other examples to be used, as suggested by @syntron in #327 (here exactly), for automatic testing.