-
Notifications
You must be signed in to change notification settings - Fork 376
test coverage test #2409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
test coverage test #2409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📊 Diff Coverage ReportDiff Coverage ReportThreshold: 80% Changed Files Coverage
Overall Coverage2/11 lines covered (18.2%) ❌ Coverage Check FailedFiles below 80% threshold:
|
abdulraqeeb33
commented
Nov 26, 2025
| * @return true if the [id] provided was created via [createLocalId]. | ||
| */ | ||
| fun isLocalId(id: String): Boolean = id.startsWith(LOCAL_PREFIX) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is extra code i have added to show case the results. I will delete this code once this PR is reviewed.
fadi-george
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Adding diff coverage in the CI/CD pipeline
Details
Adds diff coverage checking to enforce test coverage on changed code. The
checkCoverage.shscript checks coverage for files modified in the PR against the base branch. The default is set to 80% threshold.Coverage results are automatically posted as PR comments, and the build fails if coverage is below the threshold.
The
Skip Coverage Checklabel can be used to bypass the coverage step while still showing coverage results.Motivation
We need to make sure any code added to the code base needs to have proper coverage.
Scope
Limited to internal testing.
Testing
Unit testing
Added extra code for testing purposes.
Manual testing
./coverage/checkCoverage.sh
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is