cflags passthrough/v2 #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool is not required.
In the Suricata use case, we want to set CFLAGS, but not necessarily for all Rust crates. So give suricata-lua-sys its own CFLAGS environment variable which will be used when build this crate.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build script to forward external compiler flags into the shared library build, skips building the optional tool, and bumps the crate version.
- Forward
CFLAGSandSURICATA_LUA_SYS_CFLAGSintoMYCFLAGSinbuild.rs - Limit the build to the library target only
- Bump package version
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| build.rs | Pass through CFLAGS, add SURICATA_LUA_SYS_CFLAGS, constrain build to library, update rerun directives |
| Cargo.toml | Version changed from 0.1.0-alpha.6 to 0.1.0-alpha.8 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.rs: pass through CFLAGS
build.rs: only build the library not the tool
The tool is not required.
version: 0.1.0-alpha.7