Skip to content

Conversation

@asandino15
Copy link

@asandino15 asandino15 commented Dec 15, 2025

Please add to the documentation that Existing Key Vault with Private Endpoints is not supported for Azure Local Deploy process

Clarify that Azure Local does not support existing Key Vaults with Private Endpoints.
@prmerger-automator
Copy link
Contributor

@asandino15 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 5142b16:

✅ Validation status: passed

File Status Preview URL Details
azure-local/deploy/deploy-via-portal.md ✅Succeeded

For more details, please refer to the build report.

@v-dirichards v-dirichards requested a review from Copilot December 16, 2025 15:49
@v-dirichards
Copy link
Contributor

@alkohli

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Dec 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds important documentation clarifying that Azure Local deployments do not support using existing Azure Key Vaults with Private Endpoints enabled. This limitation is documented in the deployment guide to prevent deployment failures when users attempt to use Key Vaults configured with Private Endpoints.

Key Changes

  • Added an IMPORTANT alert in the Key Vault configuration section warning users about the Private Endpoints limitation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

After the extensions are installed successfully, **Add machines** by selecting from the same list of machines and then **Validate selected machines**.

1. **Select an existing Key Vault** or select **Create a new Key Vault**. Create an empty key vault to securely store secrets for this system, such as cryptographic keys, local admin credentials, and BitLocker recovery keys.
[!IMPORTANT] Azure Local does not support deploying a cluster using an existing Azure Key Vault that has Private Endpoints enabled..
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown syntax for the IMPORTANT alert is incorrect. The line should start with > to properly render as a blockquote alert in markdown documentation. Looking at line 46 as an example, the correct format should be > [!IMPORTANT] rather than just [!IMPORTANT]. Without the > prefix, this will not render correctly as an alert box in the documentation.

Suggested change
[!IMPORTANT] Azure Local does not support deploying a cluster using an existing Azure Key Vault that has Private Endpoints enabled..
> [!IMPORTANT] Azure Local does not support deploying a cluster using an existing Azure Key Vault that has Private Endpoints enabled..

Copilot uses AI. Check for mistakes.
After the extensions are installed successfully, **Add machines** by selecting from the same list of machines and then **Validate selected machines**.

1. **Select an existing Key Vault** or select **Create a new Key Vault**. Create an empty key vault to securely store secrets for this system, such as cryptographic keys, local admin credentials, and BitLocker recovery keys.
[!IMPORTANT] Azure Local does not support deploying a cluster using an existing Azure Key Vault that has Private Endpoints enabled..
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a double period at the end of the sentence. The line ends with two periods instead of one.

Suggested change
[!IMPORTANT] Azure Local does not support deploying a cluster using an existing Azure Key Vault that has Private Endpoints enabled..
[!IMPORTANT] Azure Local does not support deploying a cluster using an existing Azure Key Vault that has Private Endpoints enabled.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants