-
Notifications
You must be signed in to change notification settings - Fork 431
Add note about Key Vault Private Endpoints is not supported #4046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Clarify that Azure Local does not support existing Key Vaults with Private Endpoints.
|
@asandino15 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 5142b16: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds important documentation clarifying that Azure Local deployments do not support using existing Azure Key Vaults with Private Endpoints enabled. This limitation is documented in the deployment guide to prevent deployment failures when users attempt to use Key Vaults configured with Private Endpoints.
Key Changes
- Added an IMPORTANT alert in the Key Vault configuration section warning users about the Private Endpoints limitation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| After the extensions are installed successfully, **Add machines** by selecting from the same list of machines and then **Validate selected machines**. | ||
|
|
||
| 1. **Select an existing Key Vault** or select **Create a new Key Vault**. Create an empty key vault to securely store secrets for this system, such as cryptographic keys, local admin credentials, and BitLocker recovery keys. | ||
| [!IMPORTANT] Azure Local does not support deploying a cluster using an existing Azure Key Vault that has Private Endpoints enabled.. |
Copilot
AI
Dec 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown syntax for the IMPORTANT alert is incorrect. The line should start with > to properly render as a blockquote alert in markdown documentation. Looking at line 46 as an example, the correct format should be > [!IMPORTANT] rather than just [!IMPORTANT]. Without the > prefix, this will not render correctly as an alert box in the documentation.
| [!IMPORTANT] Azure Local does not support deploying a cluster using an existing Azure Key Vault that has Private Endpoints enabled.. | |
| > [!IMPORTANT] Azure Local does not support deploying a cluster using an existing Azure Key Vault that has Private Endpoints enabled.. |
| After the extensions are installed successfully, **Add machines** by selecting from the same list of machines and then **Validate selected machines**. | ||
|
|
||
| 1. **Select an existing Key Vault** or select **Create a new Key Vault**. Create an empty key vault to securely store secrets for this system, such as cryptographic keys, local admin credentials, and BitLocker recovery keys. | ||
| [!IMPORTANT] Azure Local does not support deploying a cluster using an existing Azure Key Vault that has Private Endpoints enabled.. |
Copilot
AI
Dec 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a double period at the end of the sentence. The line ends with two periods instead of one.
| [!IMPORTANT] Azure Local does not support deploying a cluster using an existing Azure Key Vault that has Private Endpoints enabled.. | |
| [!IMPORTANT] Azure Local does not support deploying a cluster using an existing Azure Key Vault that has Private Endpoints enabled. |
Please add to the documentation that Existing Key Vault with Private Endpoints is not supported for Azure Local Deploy process