Support Unicode text in header values #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had some problems using this library on websites that send UTF-8 encoded values for some headers (e.g. non-English text), so I changed the encoding/decoding routines to use UTF8 encoding instead of ASCII. This change should have no conflicts with the current behavior, since UTF8 will act the same as ASCII for character codes < 127 (i.e. normal text). With the existing implementation, all Unicode characters are converted to `?` in the header value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I had some problems using this library on websites that send UTF-8 encoded values for some headers (e.g. non-English text), so I changed the encoding/decoding routines to use UTF8 encoding instead of ASCII. This change should have no conflicts with the current behavior, since UTF8 will act the same as ASCII for character codes < 127 (i.e. normal text). With the existing implementation, all Unicode characters are converted to
?in the header value.