release process: Set console version whenever we bump #34377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not just in manual release cut Noticed in MaterializeInc@790c707#diff-d8516b256903c0a467dadf225f84ffb3023c18412afafdd5db11087cdbbf84e7 that we still have an old console on main and also our rc.1. This is not a huge issue because with the current process we do manually cut a new .0 version, but still should be fixed!
bosconi
approved these changes
Dec 9, 2025
Member
bosconi
left a comment
bosconi
left a comment
There was a problem hiding this comment.
Looks good. One small question.
| echo "Waiting for console version to be released on DockerHub (~15 min)" | ||
| console_version="${version#v}" | ||
| console_image="materialize/console:$console_version" | ||
| sleep $((15 * 60)) |
Member
There was a problem hiding this comment.
There's no way it will ever be available sooner than 15 mins? Checking before sleeping and starting out with the 1 minute sleep would be optimistic.
Contributor
Author
There was a problem hiding this comment.
We'd have to optimize the build for that, it currently seems to not use any caching, so it takes a minimum of 14 min based on the runs I checked. I'm more afraid we run into Docker quota and never finish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not just in manual release cut
Noticed in
790c707#diff-d8516b256903c0a467dadf225f84ffb3023c18412afafdd5db11087cdbbf84e7 that we still have an old console on main and also our rc.1.
This is not a huge issue because with the current process we do manually cut a new .0 version, but still should be fixed!
I have no way of testing this, so there is some risk that the next bump might fail.
(All of this complexity can be removed when we move console into the materialize repo)
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.