Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/delta-protocol-client/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 0.8.0 — not yet released

* Rework the `LionWebClient` class to use the new `Forest` class from the `class-core` package.
* Fix `messageKind` field for request messages of queries to *not* have the "`Request`" suffix.


## 0.7.1
Expand Down
16 changes: 8 additions & 8 deletions packages/delta-protocol-client/src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ export class LionWebClient {

async subscribeToChangingPartitions(queryId: LionWebId, parameters: SubscribeToPartitionChangesParameters): Promise<void> {
await this.makeQuery({
messageKind: "SubscribeToChangingPartitionsRequest",
messageKind: "SubscribeToChangingPartitions",
queryId,
...parameters,
protocolMessages: []
Expand All @@ -214,7 +214,7 @@ export class LionWebClient {

async subscribeToPartitionContents(queryId: LionWebId, partition: LionWebId): Promise<LionWebJsonChunk> { // TODO already deserialize, because we've got everything we need
const response = await this.makeQuery({
messageKind: "SubscribeToPartitionContentsRequest",
messageKind: "SubscribeToPartitionContents",
queryId,
partition,
protocolMessages: []
Expand All @@ -224,7 +224,7 @@ export class LionWebClient {

async unsubscribeFromPartitionContents(queryId: LionWebId, partition: LionWebId): Promise<void> {
await this.makeQuery({
messageKind: "UnsubscribeFromPartitionContentsRequest",
messageKind: "UnsubscribeFromPartitionContents",
queryId,
partition,
protocolMessages: []
Expand All @@ -236,7 +236,7 @@ export class LionWebClient {
return Promise.reject(new Error(`can't sign on after having signed off`))
}
const response = await this.makeQuery({
messageKind: "SignOnRequest",
messageKind: "SignOn",
queryId,
repositoryId,
deltaProtocolVersion: "2025.1",
Expand All @@ -248,7 +248,7 @@ export class LionWebClient {

async signOff(queryId: LionWebId): Promise<void> {
await this.makeQuery({
messageKind: "SignOffRequest",
messageKind: "SignOff",
queryId,
protocolMessages: []
} as SignOffRequest)
Expand All @@ -258,7 +258,7 @@ export class LionWebClient {

async reconnect(queryId: LionWebId, participationId: LionWebId, lastReceivedSequenceNumber: number): Promise<void> {
const response = await this.makeQuery({
messageKind: "ReconnectRequest",
messageKind: "Reconnect",
queryId,
participationId,
lastReceivedSequenceNumber,
Expand All @@ -270,7 +270,7 @@ export class LionWebClient {

async getAvailableIds(queryId: LionWebId, count: number): Promise<LionWebId[]> {
const response = await this.makeQuery({
messageKind: "GetAvailableIdsRequest",
messageKind: "GetAvailableIds",
queryId,
count,
protocolMessages: []
Expand All @@ -280,7 +280,7 @@ export class LionWebClient {

async listPartitions(queryId: LionWebId): Promise<LionWebJsonChunk> {
const response = await this.makeQuery({
messageKind: "ListPartitionsRequest",
messageKind: "ListPartitions",
queryId,
protocolMessages: []
} as ListPartitionsRequest) as ListPartitionsResponse
Expand Down
5 changes: 5 additions & 0 deletions packages/delta-protocol-common/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 0.8.0 — not yet released

* Fix `messageKind` field for request messages of queries to *not* have the "`Request`" suffix.


## 0.7.2

* Use the `propertyValueSerializerWith` function from the `class-core` package for the `deltaToCommandTranslator` and `deltaToEventTranslator` functions.
Expand Down
18 changes: 9 additions & 9 deletions packages/delta-protocol-common/src/payload/query-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export interface SubscribeToPartitionChangesParameters {
}

export interface SubscribeToChangingPartitionsRequest extends QueryMessage, SubscribeToPartitionChangesParameters {
messageKind: "SubscribeToChangingPartitionsRequest"
messageKind: "SubscribeToChangingPartitions"
}

export interface SubscribeToChangingPartitionsResponse extends QueryMessage {
Expand All @@ -45,7 +45,7 @@ export interface SubscribeToChangingPartitionsResponse extends QueryMessage {


export interface SubscribeToPartitionContentsRequest extends QueryMessage {
messageKind: "SubscribeToPartitionContentsRequest"
messageKind: "SubscribeToPartitionContents"
partition: LionWebId
}

Expand All @@ -56,7 +56,7 @@ export interface SubscribeToPartitionContentsResponse extends QueryMessage {


export interface UnsubscribeFromPartitionContentsRequest extends QueryMessage {
messageKind: "UnsubscribeFromPartitionContentsRequest"
messageKind: "UnsubscribeFromPartitionContents"
partition: LionWebId
}

Expand All @@ -66,7 +66,7 @@ export interface UnsubscribeFromPartitionContentsResponse extends QueryMessage {


export interface SignOnRequest extends QueryMessage {
messageKind: "SignOnRequest"
messageKind: "SignOn"
deltaProtocolVersion: "2025.1"
clientId: LionWebId
repositoryId: LionWebId
Expand All @@ -79,7 +79,7 @@ export interface SignOnResponse extends QueryMessage {


export interface SignOffRequest extends QueryMessage {
messageKind: "SignOffRequest"
messageKind: "SignOff"
}

export interface SignOffResponse extends QueryMessage {
Expand All @@ -88,7 +88,7 @@ export interface SignOffResponse extends QueryMessage {


export interface ReconnectRequest extends QueryMessage {
messageKind: "ReconnectRequest"
messageKind: "Reconnect"
participationId: LionWebId
lastReceivedSequenceNumber: number
}
Expand All @@ -100,7 +100,7 @@ export interface ReconnectResponse extends QueryMessage {


export interface GetAvailableIdsRequest extends QueryMessage {
messageKind: "GetAvailableIdsRequest"
messageKind: "GetAvailableIds"
count: number
}

Expand All @@ -111,7 +111,7 @@ export interface GetAvailableIdsResponse extends QueryMessage {


export interface GetAvailableIdsRequest extends QueryMessage {
messageKind: "GetAvailableIdsRequest"
messageKind: "GetAvailableIds"
count: number
}

Expand All @@ -122,7 +122,7 @@ export interface GetAvailableIdsResponse extends QueryMessage {


export interface ListPartitionsRequest extends QueryMessage {
messageKind: "ListPartitionsRequest"
messageKind: "ListPartitions"
}

export interface ListPartitionsResponse extends QueryMessage {
Expand Down
10 changes: 10 additions & 0 deletions packages/delta-protocol-repository-ws/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# Changelog

## 0.8.0 — not yet released

* Fix `messageKind` field for request messages of queries to *not* have the "`Request`" suffix.


## 0.7.2

(No changes)


## 0.7.1

(The 0.7.0 release was deprecated because its `validation` package was faulty.)
Expand Down
4 changes: 2 additions & 2 deletions packages/delta-protocol-repository-ws/src/repository-impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export class LionWebRepository {
return clientMetadata as ClientMetadata
}
switch (message.messageKind) {
case "SignOnRequest": {
case "SignOn": {
const { clientId, queryId } = message as SignOnRequest
clientMetadata.participationId = `participation-${String.fromCharCode(97 + (nextParticipationIdSequenceNumber++))}`
clientMetadata.clientId = clientId
Expand All @@ -72,7 +72,7 @@ export class LionWebRepository {
protocolMessages: []
} as SignOnResponse
}
case "SignOffRequest": {
case "SignOff": {
const { queryId } = message as SignOffRequest
clientMetadata.participationId = undefined
return {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ describe("combining delta protocol and an “adjacent” delta receiver", () =>
lowLevelClientInstantiator: ({ receiveMessageOnClient }) =>
Promise.resolve({
sendMessage: (message) => {
if (message.messageKind === "SignOnRequest") {
if (message.messageKind === "SignOn") {
receiveMessageOnClient({
messageKind: "SignOnResponse",
queryId: "q1",
Expand Down
2 changes: 1 addition & 1 deletion packages/delta-protocol-test/src/tests/scenarios.tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ describe(`scenarios (${ansi.colorSchemeExplanationString})`, async function() {
}]
}
const expectedLogItems = [
new RepositoryReceivedMessage({}, { messageKind: "SignOnRequest", queryId, repositoryId, deltaProtocolVersion: "2025.1", clientId, protocolMessages: [] } as SignOnRequest),
new RepositoryReceivedMessage({}, { messageKind: "SignOn", queryId, repositoryId, deltaProtocolVersion: "2025.1", clientId, protocolMessages: [] } as SignOnRequest),
new ClientReceivedMessage(clientId, { messageKind: "SignOnResponse", queryId, participationId: "participation-a", protocolMessages: [] } as SignOnResponse),
new DeltaOccurredOnClient(
clientId,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe("mock low-level client", async function() {
}

const signOnQueryRequest: SignOnRequest = {
messageKind: "SignOnRequest",
messageKind: "SignOn",
deltaProtocolVersion: "2025.1",
clientId: "A",
queryId: "query-1",
Expand Down
2 changes: 1 addition & 1 deletion packages/json/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

## 0.7.2

(No changes.)
(No changes)


## 0.7.1
Expand Down
3 changes: 2 additions & 1 deletion packages/validation/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@
* New way to define the structure of the LionWeb JSON format.
* Add delta format definitions.
* Propagate `reference` field of `LionWebJsonReferenceTarget` type now being `null`able.
* Fix `messageKind` field for request messages of queries to *not* have the "`Request`" suffix.


## 0.7.2

(No changes.)
(No changes)


## 0.7.1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const QueryDefinitions: MessageGroup = {
],
messages: [
{
name: "SubscribeToChangingPartitionsRequest",
name: "SubscribeToChangingPartitions",
properties: [
{
name: "creation",
Expand All @@ -54,7 +54,7 @@ export const QueryDefinitions: MessageGroup = {
],
},
{
name: "SubscribeToPartitionContentsRequest",
name: "SubscribeToPartitionContents",
properties: [
{
name: "partition",
Expand All @@ -66,7 +66,7 @@ export const QueryDefinitions: MessageGroup = {
],
},
{
name: "UnsubscribeFromPartitionContentsRequest",
name: "UnsubscribeFromPartitionContents",
properties: [
{
name: "partition",
Expand All @@ -78,7 +78,7 @@ export const QueryDefinitions: MessageGroup = {
],
},
{
name: "SignOnRequest",
name: "SignOn",
properties: [
{
name: "deltaProtocolVersion",
Expand All @@ -104,11 +104,11 @@ export const QueryDefinitions: MessageGroup = {
],
},
{
name: "signOffRequest",
name: "signOff",
properties: [],
},
{
name: "ReconnectRequest",
name: "Reconnect",
properties: [
{
name: "participationId",
Expand All @@ -127,7 +127,7 @@ export const QueryDefinitions: MessageGroup = {
],
},
{
name: "GetAvailableIdsRequest",
name: "GetAvailableIds",
properties: [
{
name: "count",
Expand All @@ -139,7 +139,7 @@ export const QueryDefinitions: MessageGroup = {
],
},
{
name: "ListPartitionsRequest",
name: "ListPartitions",
properties: [],
},
],
Expand Down