-
Notifications
You must be signed in to change notification settings - Fork 1
Create integrated documentation #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| { | ||
| Key = "key-lang", | ||
| Version = "0", | ||
| Name = "Complaints Language", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a valid name -- we defined all IKeyed names must be valid programming identifiers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right
dslmeinte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
| { | ||
| public static void Run() | ||
| { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is a TODO, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I will remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a duplicate of the file directly under examples-ts/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, removing a copy
|
|
||
| ```shell | ||
| # Run the tests | ||
| npm run test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"npm test" does the same thing, and is slightly more ideomatic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted, thank you
|
Merging, after discussion during the meeting and because approved by Meinte |
This is a draft PR, as requested by @enikao .
In this PR we:
I then plan to add a GitHub action to manage the publication, similarly to what we do here.
The quality of the documentation is not great, but I hope it can serve as a starting point and that we can then incrementally improving it over time.
To check the documentation, run
npm run startfrom the website directory.Todo