[WIP] doc: A couple of typo fixes and requests for clarification #691
Conversation
pfalcon
commented
Apr 17, 2020
pfalcon
commented
- Fix a couple of genuine typos.
- Clarify a few points which I think I could myself (need confirmation from maintainers).
- Pinpoint even more points which could provide a bit more information - these would need input from maintainers.
Signed-off-by: Paul Sokolovsky <paul.sokolovsky@linaro.org>
Signed-off-by: Paul Sokolovsky <paul.sokolovsky@linaro.org>
pfalcon
requested review from
chaws,
mwasilew,
stevanradakovic and
terceiro
as code owners
| Both forms are supported. In case log entry is missing or simple JSON | ||
| format is used, logs for each Test object are empty. They can be filled | ||
| in using plugins. | ||
| in using plugins [at later time??]. |
There was a problem hiding this comment.
@pfalcon yes! After results are fetched, enabled plugins will post-process tests seeking for extra logs. One example is a built-in plugin linux-log-parser, which searches job log for linux kernel oopsies, then create tests for each specific type of oops (kernel-panic, warning, bug, etc)
There was a problem hiding this comment.
I propose to change it like this:
"They can be filled in using plugins in a post-processing step. This happens after all results are collected in SQUAD"
| * ``resubmit_url``: URL that can be used to resubmit the test run. | ||
| * ``resubmit_url``: URL that can be used to resubmit the test run. [As in: this is | ||
| API-level URL, which, being accessed, would trigged a resubmit (auth is an obvious concern), | ||
| or this is UI-level page, which user can open, login if needed and press "Resubmit" button?] |
There was a problem hiding this comment.
This is actually the URL that was used to resubmit a job. For instance, if you visit a build's testjob tab, you get a list of testjobs and a blue button next to it that allow you to resubmit that job. Then the resubmit-url is that new url, mostly with a new job id in it.
|
@chaws: Thanks for your comments! Will try to integrate them into next version of the patch. (But currently switching to other tasks, so that may take some time.) |
| a hash (an object, strictly speaking). Metric names go in the keys, and | ||
| values must be either a single number, or an array of numbers. In the | ||
| case of an array of numbers, then their mean will be used as the metric | ||
| case of an array of numbers, then their mean [or average? elaborate] will be used as the metric |
There was a problem hiding this comment.
3 participants
