feat(wrapped-keys): add versioned key update support and client APIs #1007

Ansonhkg · 2025-12-09T22:11:34Z

WHAT

Same as #1006, but for V8 Naga

TEST

...

Copilot

Pull request overview

This PR adds versioned key update support to the wrapped-keys package, enabling rotation of encrypted key ciphertext while preserving historical versions. This is part of the V8 Naga release and mirrors functionality from PR #1006.

Key Changes:

Adds updateEncryptedKey API function for rotating wrapped key ciphertext with version tracking
Extends metadata types to support optional updatedAt timestamps and versions history
Introduces includeVersions query parameter to optionally fetch version history

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`packages/wrapped-keys/src/lib/types.ts`	Adds `WrappedKeyVersion`, `UpdateEncryptedKeyParams`, and `UpdateEncryptedKeyResult` types; extends existing metadata types with `updatedAt` and `versions` fields
`packages/wrapped-keys/src/lib/service-client/types.ts`	Adds `UpdateKeyParams` interface and extends HTTP method union to include `PUT`
`packages/wrapped-keys/src/lib/service-client/client.ts`	Implements `updatePrivateKey` function and adds `includeVersions` query parameter support to `fetchPrivateKey`
`packages/wrapped-keys/src/lib/api/update-encrypted-key.ts`	New API wrapper function that orchestrates key updates using PKP session signatures
`packages/wrapped-keys/src/lib/api/index.ts`	Exports the new `updateEncryptedKey` function
`packages/wrapped-keys/src/lib/api/get-encrypted-key.ts`	Passes through `includeVersions` parameter to service client
`packages/wrapped-keys/src/lib/service-client/index.ts`	Exports the new `updatePrivateKey` function
`packages/wrapped-keys/src/index.ts`	Exports new API function and types for public consumption
`packages/e2e/src/test-helpers/executeJs/wrappedKeys.ts`	Adds comprehensive E2E test validating update functionality and version history retrieval

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/wrapped-keys/src/lib/api/update-encrypted-key.ts

packages/wrapped-keys/src/lib/types.ts

Copilot · 2025-12-09T22:19:00Z

packages/wrapped-keys/src/lib/types.ts

+  updatedAt?: string;
+  versions?: WrappedKeyVersion[];


The new updatedAt and versions properties should be documented in the JSDoc comment above. Add property descriptions following the established pattern:

* @property { string } [updatedAt] ISO 8601 timestamp of when the key was last updated * @property { WrappedKeyVersion[] } [versions] Array of historical versions of this key after update operations

@copilot open a new pull request to apply changes based on this feedback

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/wrapped-keys/src/lib/types.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Anson <ansonox@gmail.com>

Copilot · 2025-12-10T16:35:36Z

@Ansonhkg I've opened a new pull request, #1009, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-10T16:35:48Z

@Ansonhkg I've opened a new pull request, #1010, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-10T16:35:55Z

@Ansonhkg I've opened a new pull request, #1011, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-10T16:35:59Z

@Ansonhkg I've opened a new pull request, #1012, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Ansonhkg <4049673+Ansonhkg@users.noreply.github.com>

…adata Co-authored-by: Ansonhkg <4049673+Ansonhkg@users.noreply.github.com>

Co-authored-by: Ansonhkg <4049673+Ansonhkg@users.noreply.github.com>

…rams Co-authored-by: Ansonhkg <4049673+Ansonhkg@users.noreply.github.com>

[WIP] Address feedback on versioned key update support

CLAassistant · 2025-12-10T16:41:25Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Ansonhkg
❌ Copilot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

…r-one [WIP] Address feedback on versioned key update support

[WIP] Address feedback on versioned key update support

Add detailed JSDoc documentation to UpdateEncryptedKeyResult interface

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/e2e/src/test-helpers/executeJs/wrappedKeys.ts

packages/wrapped-keys/src/lib/types.ts

packages/wrapped-keys/src/lib/api/update-encrypted-key.ts

Copilot · 2025-12-10T17:00:19Z

@Ansonhkg I've opened a new pull request, #1013, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-10T17:00:23Z

@Ansonhkg I've opened a new pull request, #1014, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Anson <ansonox@gmail.com>

Co-authored-by: Ansonhkg <4049673+Ansonhkg@users.noreply.github.com>

…re-time Add test coverage for evmContractConditions in updateEncryptedKey

…-work Add JSDoc documentation for UpdateEncryptedKeyParams type

Ansonhkg · 2025-12-10T17:41:11Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2025-12-10T17:41:19Z

@Ansonhkg I've opened a new pull request, #1015, to work on those changes. Once the pull request is ready, I'll request review from you.

…ped-keys-naga

feat(wrapped-keys): add versioned key update support and client APIs

adea77a

Copilot AI review requested due to automatic review settings December 9, 2025 22:11

Ansonhkg added the v8 | Naga label Dec 9, 2025

Copilot started reviewing on behalf of Ansonhkg December 9, 2025 22:12 View session

chore(version): add changeset

3a644ec

Copilot AI reviewed Dec 9, 2025

View reviewed changes

Ansonhkg requested review from DashKash54, Copilot and glitch003 December 9, 2025 23:45

Copilot started reviewing on behalf of Ansonhkg December 9, 2025 23:45 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

packages/wrapped-keys/src/lib/types.ts Outdated Show resolved Hide resolved

packages/wrapped-keys/src/lib/types.ts Outdated Show resolved Hide resolved

packages/wrapped-keys/src/lib/types.ts Show resolved Hide resolved

Ansonhkg and others added 2 commits December 10, 2025 16:35

Update packages/wrapped-keys/src/lib/api/update-encrypted-key.ts

e381b1f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Anson <ansonox@gmail.com>

Initial plan

4ec70bd

Copilot AI mentioned this pull request Dec 10, 2025

Add detailed JSDoc documentation to UpdateEncryptedKeyResult interface #1009

Merged

14 tasks

Initial plan

f6a6538

Copilot AI mentioned this pull request Dec 10, 2025

[WIP] Address feedback on versioned key update support #1010

Merged

5 tasks

Initial plan

b987f1d

Copilot AI mentioned this pull request Dec 10, 2025

[WIP] Address feedback on versioned key update support #1011

Merged

4 tasks

Initial plan

47ca9e9

Copilot AI mentioned this pull request Dec 10, 2025

[WIP] Address feedback on versioned key update support #1012

Merged

4 tasks

Copilot AI and others added 5 commits December 10, 2025 16:37

docs(wrapped-keys): add detailed JSDoc for UpdateEncryptedKeyResult

8a56af2

Co-authored-by: Ansonhkg <4049673+Ansonhkg@users.noreply.github.com>

docs: add JSDoc for updatedAt and versions properties in StoredKeyMet…

04395fd

…adata Co-authored-by: Ansonhkg <4049673+Ansonhkg@users.noreply.github.com>

Add detailed JSDoc documentation to WrappedKeyVersion interface

14ae7a8

Co-authored-by: Ansonhkg <4049673+Ansonhkg@users.noreply.github.com>

docs: add JSDoc for includeVersions property in GetEncryptedKeyDataPa…

3553f15

…rams Co-authored-by: Ansonhkg <4049673+Ansonhkg@users.noreply.github.com>

Merge pull request #1012 from LIT-Protocol/copilot/sub-pr-1007-yet-again

a702d21

[WIP] Address feedback on versioned key update support

Ansonhkg added 3 commits December 10, 2025 16:41

Merge pull request #1011 from LIT-Protocol/copilot/sub-pr-1007-anothe…

e35409f

…r-one [WIP] Address feedback on versioned key update support

Merge pull request #1010 from LIT-Protocol/copilot/sub-pr-1007-again

a58e77e

[WIP] Address feedback on versioned key update support

Merge pull request #1009 from LIT-Protocol/copilot/sub-pr-1007

209229e

Add detailed JSDoc documentation to UpdateEncryptedKeyResult interface

Ansonhkg requested a review from Copilot December 10, 2025 16:43

Copilot started reviewing on behalf of Ansonhkg December 10, 2025 16:44 View session

Copilot AI reviewed Dec 10, 2025

View reviewed changes

Ansonhkg and others added 2 commits December 10, 2025 16:52

doc: add wrapped keys doc

e58308c

Initial plan

79fe914

Copilot AI mentioned this pull request Dec 10, 2025

Add test coverage for evmContractConditions in updateEncryptedKey #1013

Merged

14 tasks

Initial plan

fb3817e

Copilot AI mentioned this pull request Dec 10, 2025

Add JSDoc documentation for UpdateEncryptedKeyParams type #1014

Merged

14 tasks

Ansonhkg and others added 7 commits December 10, 2025 17:00

Update packages/wrapped-keys/src/lib/api/update-encrypted-key.ts

a43b122

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Anson <ansonox@gmail.com>

docs: add detailed JSDoc documentation to UpdateEncryptedKeyParams

505e2cf

Co-authored-by: Ansonhkg <4049673+Ansonhkg@users.noreply.github.com>

Add test for updateEncryptedKey with evmContractConditions

582bbc2

Co-authored-by: Ansonhkg <4049673+Ansonhkg@users.noreply.github.com>

Use realistic EVM contract conditions in test helper

7b18213

Co-authored-by: Ansonhkg <4049673+Ansonhkg@users.noreply.github.com>

Remove unused address parameter from createEvmContractConditions

be45d0f

Co-authored-by: Ansonhkg <4049673+Ansonhkg@users.noreply.github.com>

Merge pull request #1013 from LIT-Protocol/copilot/sub-pr-1007-one-mo…

49de446

…re-time Add test coverage for evmContractConditions in updateEncryptedKey

Merge pull request #1014 from LIT-Protocol/copilot/sub-pr-1007-please…

688284e

…-work Add JSDoc documentation for UpdateEncryptedKeyParams type

Copilot AI mentioned this pull request Dec 10, 2025

docs(wrapped-keys): complete JSDoc documentation for versioned key update APIs #1015

Closed

15 tasks

Merge branch 'naga' into feature/jss-141-add-update-function-for-wrap…

9714eed

…ped-keys-naga

feat(wrapped-keys): add versioned key update support and client APIs #1007

Are you sure you want to change the base?

feat(wrapped-keys): add versioned key update support and client APIs #1007

Conversation

Ansonhkg commented Dec 9, 2025

WHAT

TEST

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Ansonhkg Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Dec 10, 2025

Uh oh!

Copilot AI commented Dec 10, 2025

Uh oh!

Copilot AI commented Dec 10, 2025

Uh oh!

Copilot AI commented Dec 10, 2025

Uh oh!

CLAassistant commented Dec 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Dec 10, 2025

Uh oh!

Copilot AI commented Dec 10, 2025

Uh oh!

Ansonhkg commented Dec 10, 2025

Uh oh!

Copilot AI commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants