-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add back update contributors script #4241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
I ran the script, this is what it produced: https://github.com/Kilo-Org/kilocode/blob/d490746ff09a4f2e94f60501b7b26b489af3ef9c/README.md#contributing The contributors are sorted by contributions desc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reintroduces the update-contributors script to automatically fetch and display GitHub contributors in the README. The script replaces a previous implementation that fetched data from an external JSON endpoint with a direct GitHub API integration.
Key changes:
- Rewrites
scripts/update-contributors.jsto use the GitHub API directly instead of fetching from kilo.ai/contributors.json - Changes from ES modules to CommonJS for consistency with other scripts in the repository
- Adds an npm script
update-contributorstopackage.jsonfor easy execution - Updates README.md with a new table-based contributor display format (6 columns) and filters out bot accounts
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| scripts/update-contributors.js | Complete rewrite of the contributors script using GitHub API, CommonJS modules, and improved error handling |
| package.json | Adds update-contributors npm script for convenient execution |
| README.md | Updates contributors section with new auto-generated table format displaying all contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ No Issues Found
3 files reviewed | Confidence: 90% | Recommendation: Merge
Review Details
Files: scripts/update-contributors.js, package.json, README.md
Checked: Security, bugs, error handling, code quality
Notes:
- Previous Copilot review comments have been addressed or intentionally dismissed by the author
- The
Bearertoken format is now correct (line 19) - The script properly handles GitHub API errors with status code checks
- Bot filtering logic correctly excludes
[bot]andR00-B0Taccounts - The 100 contributor limit is acceptable per author's decision
- README.md changes are auto-generated content with proper markers
Minor observations (not blocking):
- The
updateReadmefunction returnsundefinedwhen markers are missing, but author confirmed this fail-hard behavior is intentional - No success message is logged after completion, but author confirmed this is acceptable
Context
Add back the
update-contributorsscript. We want to highlight the amazing members of our community!