Skip to content

Logging: define isless between Integer and LogLevel #60330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EdsterG wants to merge 3 commits into
base: master
Choose a base branch
from
+9 −0
Open

Logging: define isless between Integer and LogLevel #60330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f6cfde
define isless between Integer and LogLevel
EdsterG Dec 5, 2025
9e1827e
add tests
EdsterG Dec 5, 2025
58b0458
Merge branch 'master' into logging_fix
EdsterG Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions base/logging/logging.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ end
LogLevel(level::LogLevel) = level

isless(a::LogLevel, b::LogLevel) = isless(a.level, b.level)
isless(a::LogLevel, b::Integer) = isless(a.level, b)
isless(a::Integer, b::LogLevel) = isless(a, b.level)
+(level::LogLevel, inc::Integer) = LogLevel(level.level+inc)
-(level::LogLevel, inc::Integer) = LogLevel(level.level-inc)
convert(::Type{LogLevel}, level::Integer) = LogLevel(level)
Expand Down
7 changes: 7 additions & 0 deletions stdlib/Logging/test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@ macro customlog(exs...) Base.CoreLogging.logmsg_code((Base.CoreLogging.@_sourcei
@test :handle_message in names(Logging, all=true) # non-exported public function
end

@testset "LogLevel compatibility with integers" begin
@test Logging.Debug + 1000 == Logging.Info
@test Logging.Warn - 1000 == Logging.Info
@test Logging.Info < 500
@test 500 < Logging.Warn
end

@testset "ConsoleLogger" begin
# First pass log limiting
@test min_enabled_level(ConsoleLogger(devnull, Logging.Debug)) == Logging.Debug
Expand Down
Loading