-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Use NVTX payload API #60322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Use NVTX payload API #60322
Conversation
vchuravy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this backwards compatible? E.g. does the NVTX client work with older versions of NSight?
| jl_timing_show((jl_value_t *)method, cur_block); | ||
| #ifdef USE_NVTX | ||
|
|
||
| #endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is something missing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I need to figure out a way to extract the method signature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#58702 Does this help at all?
| jl_timing_printf(cur_block, "%s", jl_symbol_name(macro->def.method->name)); | ||
| #ifdef USE_NVTX | ||
|
|
||
| #endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
Yes, but there was an issue where the full payloads weren't displayed correctly. |
455b956 to
6e71aff
Compare
This adds more information to the NVTX annotations when profiling with Nsight Systems (e.g. file, line number, method when compiling)
Requires Nsight Systems 2025.6.1