Skip to content

Conversation

@simonbyrne
Copy link
Member

This adds more information to the NVTX annotations when profiling with Nsight Systems (e.g. file, line number, method when compiling)

Requires Nsight Systems 2025.6.1

Screenshot 2025-12-04 at 10 16 53 PM

Copy link
Member

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this backwards compatible? E.g. does the NVTX client work with older versions of NSight?

jl_timing_show((jl_value_t *)method, cur_block);
#ifdef USE_NVTX

#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is something missing here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I need to figure out a way to extract the method signature.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#58702 Does this help at all?

jl_timing_printf(cur_block, "%s", jl_symbol_name(macro->def.method->name));
#ifdef USE_NVTX

#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@simonbyrne
Copy link
Member Author

simonbyrne commented Dec 5, 2025

Is this backwards compatible? E.g. does the NVTX client work with older versions of NSight?

Yes, but there was an issue where the full payloads weren't displayed correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants