fix(cairo_render): fix UB #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Keno can this be merged and tagged as a patch release? |
Keno
reviewed
May 19, 2025
| push!(format_placeholder, UInt8(0)) | ||
| format_cstring = pointer(format_placeholder) | ||
|
|
||
| ret = ccall((:gvRenderContext,libgvc),Cint,(Ptr{Cvoid},Ptr{Cvoid},Ptr{UInt8},Ptr{Cvoid}),context.handle,g.handle,format_cstring,C_NULL) |
Contributor
There was a problem hiding this comment.
This is all not gc-safe. Just declare this as Cstring rather than Ptr{UInt8} and let julia worry about the string conversion.
|
Any chance that this beeing merged in the future ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is described here:
JuliaLang/julia#56150
#45
ReactiveBayes/GraphPPL.jl/pull/268
These changes fixed the issue for me. However, I need the
cairo_renderonly, so, most likely, the other functions should be fixed in the same way to clear all bugs.